Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property tests for standard functions generates mostly big ints #54

Closed
Acaccia opened this issue Aug 28, 2023 · 0 comments · Fixed by #87
Closed

Property tests for standard functions generates mostly big ints #54

Acaccia opened this issue Aug 28, 2023 · 0 comments · Fixed by #87
Assignees

Comments

@Acaccia
Copy link
Collaborator

Acaccia commented Aug 28, 2023

In the property tests in property_tests.rs, the generated i128 for the property tests are mostly big integers, and don't really test that functions still works for smaller ints.

We should split the int128() into several prop_compose, to have more control on the size we want to get.

I would propose at least:

  • small_uint128: i <= u64::MAX
  • big_uint128: i > u64::MAX
  • positive_int128
  • negative_int128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant