Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the quantity of property tests #87

Merged
merged 11 commits into from Sep 19, 2023
Merged

Conversation

Acaccia
Copy link
Collaborator

@Acaccia Acaccia commented Sep 15, 2023

Fixes #54

Now we have a huge load of tests, on all kind of ranges of integers, in all configurations.

Good thing, most stuffs work.
Bad thing, the multiplication doesn't.

UPDATE:
Finally everything works:

  • mul-uint had a stupid mistake in the case where the sum of leading zeros was 127 and b is odd
  • mul-int overflow detection didn't work. The new algorithm does.
  • there was a mistake in the proptests of sqrti-int.

@Acaccia Acaccia self-assigned this Sep 15, 2023
@Acaccia Acaccia marked this pull request as ready for review September 18, 2023 19:32
Copy link
Collaborator

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor comments. Looks great. Thanks for fixing this!

clar2wasm/src/standard/standard.wat Outdated Show resolved Hide resolved
clar2wasm/src/standard/standard.wat Show resolved Hide resolved
Copy link
Collaborator

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Acaccia Acaccia added this pull request to the merge queue Sep 19, 2023
Merged via the queue into main with commit b65494d Sep 19, 2023
4 checks passed
@Acaccia Acaccia deleted the feat/more-thorough-proptests branch September 19, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Property tests for standard functions generates mostly big ints
2 participants