Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement trait functions #154

Merged
merged 8 commits into from Nov 6, 2023
Merged

Implement trait functions #154

merged 8 commits into from Nov 6, 2023

Conversation

obycode
Copy link
Collaborator

@obycode obycode commented Nov 3, 2023

Description

Added support for define-trait, use-trait, and impl-trait.
Added TestEnvironment in tools to enable testing that requires "deploying" multiple contracts.

The test for actually calling a method from the trait is ignored for now until the dynamic contract calls are implemented. I'll work on that next.

Part of issue #143

`add_identifier_string_literal` is now `add_string_literal` and
`add_string_literal` is not `add_clarity_string_literal`.
`define-trait`, `use-trait`, and `impl-trait`
This now enables "deploying" multiple contracts in the tests.
@obycode obycode requested a review from krl November 3, 2023 16:59
@obycode obycode mentioned this pull request Nov 3, 2023
5 tasks
@obycode
Copy link
Collaborator Author

obycode commented Nov 4, 2023

I went ahead and added the dynamic contract call support to this PR as well.

Copy link
Collaborator

@krl krl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking very good, cannot find anything to complain about

clar2wasm/src/wasm_generator.rs Show resolved Hide resolved
@obycode obycode added this pull request to the merge queue Nov 6, 2023
Merged via the queue into main with commit 622ec83 Nov 6, 2023
4 checks passed
@obycode obycode deleted the feat/trait-functions branch November 6, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants