generated from stacks-network/.github
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement trait functions #154
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`add_identifier_string_literal` is now `add_string_literal` and `add_string_literal` is not `add_clarity_string_literal`.
`define-trait`, `use-trait`, and `impl-trait`
This now enables "deploying" multiple contracts in the tests.
obycode
force-pushed
the
feat/trait-functions
branch
from
November 3, 2023 16:48
18cfe04
to
adacfba
Compare
I went ahead and added the dynamic contract call support to this PR as well. |
This was referenced Nov 4, 2023
Merged
krl
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking very good, cannot find anything to complain about
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for
define-trait
,use-trait
, andimpl-trait
.Added
TestEnvironment
in tools to enable testing that requires "deploying" multiple contracts.The test for actually calling a method from the trait is ignored for now until the dynamic contract calls are implemented. I'll work on that next.
Part of issue #143