Moving types and helper functions to a new typescript sbtc library #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
0af6020
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0d6aba7f.sbtc-bridge.pages.dev |
| Branch Preview URL: | https://feat-133-create-typescript-b.sbtc-bridge.pages.dev |
Merged
radicleart
added a commit
that referenced
this pull request
May 19, 2023
* 1. bug - wrong network selected in peg out flow. (#127) 2. refactored code in the deposit / commit / reveal 3. added settings switch to test the flow with random private key * Begun support for reclaiming unspent - WP Refactored the two build views for deposits and Withdrawals to make them simpler. * Feat/128 as a user i want to spend the reclaim script path (#134) * 1. bug - wrong network selected in peg out flow. (#127) (#129) 2. refactored code in the deposit / commit / reveal 3. added settings switch to test the flow with random private key * Begun support for reclaiming unspent - WP Refactored the two build views for deposits and Withdrawals to make them simpler. * Chore: test fixes * Moving types and helper functions to a new typescript sbtc library (#135) * Moving types and helper functions to a new typescript sbtc library * Added some unit tests for building and parsing deposit/withdrawal payloads * Published and installed sbtc-bridge-lib to npm repo
radicleart
added a commit
that referenced
this pull request
May 19, 2023
* 1. bug - wrong network selected in peg out flow. (#127) 2. refactored code in the deposit / commit / reveal 3. added settings switch to test the flow with random private key * Begun support for reclaiming unspent - WP Refactored the two build views for deposits and Withdrawals to make them simpler. * Feat/128 as a user i want to spend the reclaim script path (#134) * 1. bug - wrong network selected in peg out flow. (#127) (#129) 2. refactored code in the deposit / commit / reveal 3. added settings switch to test the flow with random private key * Begun support for reclaiming unspent - WP Refactored the two build views for deposits and Withdrawals to make them simpler. * Chore: test fixes * Moving types and helper functions to a new typescript sbtc library (#135) * Moving types and helper functions to a new typescript sbtc library * Added some unit tests for building and parsing deposit/withdrawal payloads * Published and installed sbtc-bridge-lib to npm repo * Bug/137 bug deposit amount tracks utxo set (#138) * Bug- remove checks vs UTXO set from peg in amount * Bug- remove pay with web wallet if balance is less than deposit value * chore: unit tests
radicleart
added a commit
that referenced
this pull request
May 24, 2023
* 1. bug - wrong network selected in peg out flow. (#127) 2. refactored code in the deposit / commit / reveal 3. added settings switch to test the flow with random private key * Begun support for reclaiming unspent - WP Refactored the two build views for deposits and Withdrawals to make them simpler. * Feat/128 as a user i want to spend the reclaim script path (#134) * 1. bug - wrong network selected in peg out flow. (#127) (#129) 2. refactored code in the deposit / commit / reveal 3. added settings switch to test the flow with random private key * Begun support for reclaiming unspent - WP Refactored the two build views for deposits and Withdrawals to make them simpler. * Chore: test fixes * Moving types and helper functions to a new typescript sbtc library (#135) * Moving types and helper functions to a new typescript sbtc library * Added some unit tests for building and parsing deposit/withdrawal payloads * Published and installed sbtc-bridge-lib to npm repo * Bug/137 bug deposit amount tracks utxo set (#138) * Bug- remove checks vs UTXO set from peg in amount * Bug- remove pay with web wallet if balance is less than deposit value * chore: unit tests * Chore: added .npmignore so npm registry doesn't use .gitignore to ignore the dist directory and simplified imports. * Updated lib imports for docker environment - works a little different from command line Renamed field btcTxid to btcTxId * Updated lib imports for docker environment - works a little different from command line * Switched the cardinal stacks bitcoin address to ordinal. Taproot spend paths require bech32m addresses. * no message * bug: path rename
radicleart
added a commit
that referenced
this pull request
May 30, 2023
* 1. bug - wrong network selected in peg out flow. (#127) 2. refactored code in the deposit / commit / reveal 3. added settings switch to test the flow with random private key * Begun support for reclaiming unspent - WP Refactored the two build views for deposits and Withdrawals to make them simpler. * Feat/128 as a user i want to spend the reclaim script path (#134) * 1. bug - wrong network selected in peg out flow. (#127) (#129) 2. refactored code in the deposit / commit / reveal 3. added settings switch to test the flow with random private key * Begun support for reclaiming unspent - WP Refactored the two build views for deposits and Withdrawals to make them simpler. * Chore: test fixes * Moving types and helper functions to a new typescript sbtc library (#135) * Moving types and helper functions to a new typescript sbtc library * Added some unit tests for building and parsing deposit/withdrawal payloads * Published and installed sbtc-bridge-lib to npm repo * Bug/137 bug deposit amount tracks utxo set (#138) * Bug- remove checks vs UTXO set from peg in amount * Bug- remove pay with web wallet if balance is less than deposit value * chore: unit tests * Move the reveal/reclaim pubkeys server side. * Chore: test fix. * Aligned unwrap with wrap by altering the flow to be op_drop only. * Holding back design changes for their own PR. * Holding back design changes for their own PR. * Aligned unwrap with wrap by altering the flow to be op_drop only. * bug - limit on max amount of withdraw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.