-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add bootstrap nodes to /v2/neighbors #3401
Conversation
Adding the bootstrap nodes to this endpoint will help new nodes discover reliable nodes to boot from.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @obycode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## develop #3401 +/- ##
===========================================
- Coverage 32.24% 32.23% -0.02%
===========================================
Files 261 261
Lines 212119 212139 +20
===========================================
- Hits 68407 68373 -34
- Misses 143712 143766 +54
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
commit 3a5c975 Merge: 793f8ed 136063f Author: Jude Nelson <judecn@gmail.com> Date: Fri Dec 16 15:56:28 2022 +0000 Merge pull request #3444 from stacks-network/chore/merge-develop-to-next Chore/merge develop to next commit 136063f Author: Jude Nelson <judecn@gmail.com> Date: Fri Dec 16 00:29:06 2022 -0500 fix: fix some failing tests commit 29342a9 Merge: 4690da5 3aa37b2 Author: Jude Nelson <judecn@gmail.com> Date: Thu Dec 15 16:34:18 2022 -0500 Merge branch 'develop' into chore/merge-develop-to-next commit 3aa37b2 Merge: 16bbcd3 4fb8377 Author: Jude Nelson <judecn@gmail.com> Date: Thu Dec 15 21:25:26 2022 +0000 Merge pull request #3445 from stacks-network/fix/trim-namespace-names-in-peer-config-names-in-tests fix(test): Remove namespace information in function_names in tests commit 4fb8377 Author: Mårten Blankfors <marten@blankfors.se> Date: Thu Dec 15 18:02:27 2022 +0100 fix(test): Remove namespace information in function_names in tests commit 4690da5 Author: Jude Nelson <judecn@gmail.com> Date: Thu Dec 15 09:03:13 2022 -0500 chore: cargo fmt commit 4e74929 Merge: 793f8ed 16bbcd3 Author: Jude Nelson <judecn@gmail.com> Date: Thu Dec 15 09:03:01 2022 -0500 Merge branch 'develop' into chore/merge-develop-to-next commit 793f8ed Merge: 0e615ec a71871a Author: Jude Nelson <judecn@gmail.com> Date: Thu Dec 15 08:53:56 2022 -0500 Merge branch 'master' into chore/merge-master-to-next commit 16bbcd3 Merge: 16db2b7 af6ce87 Author: Jude Nelson <judecn@gmail.com> Date: Mon Dec 12 16:07:44 2022 +0000 Merge pull request #3430 from stacks-network/refactor/introduce-function-name-macro-in-tests Refactor/introduce function name macro in tests commit af6ce87 Author: Mårten Blankfors <marten@blankfors.se> Date: Mon Dec 5 12:00:09 2022 +0100 fix(test): Replace invalid test name characters in smart contract name construction commit 3e0ac2e Author: Mårten Blankfors <marten@blankfors.se> Date: Fri Dec 2 11:58:14 2022 +0100 refactor: Introduce stdext and use stdext::function_name!() in tests with hard-coded function names commit 16db2b7 Merge: 2709fca 79b1869 Author: Jude Nelson <judecn@gmail.com> Date: Thu Dec 8 21:57:41 2022 +0000 Merge pull request #3434 from stacks-network/fix/3196 Simplifying README #3196 commit 79b1869 Author: wileyj <2847772+wileyj@users.noreply.github.com> Date: Thu Dec 8 11:39:07 2022 -0800 remove commented badges commit 41a8afb Merge: 6954cb4 2709fca Author: Jude Nelson <judecn@gmail.com> Date: Thu Dec 8 14:44:39 2022 +0000 Merge branch 'develop' into fix/3196 commit 2709fca Merge: d64a830 3c7b935 Author: Jude Nelson <judecn@gmail.com> Date: Thu Dec 8 14:44:26 2022 +0000 Merge pull request #3435 from stacks-network/fix/ci/upgrade-and-lock-clarinet-core-contract-tests Fix/ci/upgrade and lock clarinet core contract tests commit 3c7b935 Author: Mårten Blankfors <marten@blankfors.se> Date: Thu Dec 8 10:39:53 2022 +0100 fix(ci): Upgrade Clarinet deno library and lock Clarinet version in CI commit 6954cb4 Author: wileyj <2847772+wileyj@users.noreply.github.com> Date: Wed Dec 7 12:35:19 2022 -0800 Updating docs - breaking out sections to ./docs - adding badges - updating some text/links commit d64a830 Merge: f15c5b8 a4d4c3b Author: Jude Nelson <judecn@gmail.com> Date: Sun Dec 4 18:44:37 2022 +0000 Merge pull request #3425 from stacks-network/fix/miner-test-peer-config-fix Fix/miner test peer config fix commit a71871a Merge: a0393e4 b96ae32 Author: Jude Nelson <judecn@gmail.com> Date: Thu Dec 1 14:45:09 2022 +0000 Merge pull request #3424 from stacks-network/release/2.05.0.6.0 Release/2.05.0.6.0 commit a4d4c3b Author: Mårten Blankfors <marten@blankfors.se> Date: Thu Dec 1 11:42:25 2022 +0100 fix(test): Wrong test name in a TestPeerConfig commit b96ae32 Merge: acc5009 f15c5b8 Author: Jude Nelson <judecn@gmail.com> Date: Mon Nov 28 12:06:50 2022 -0500 Merge branch 'develop' into release/2.05.0.6.0 commit acc5009 Author: Jude Nelson <judecn@gmail.com> Date: Mon Nov 28 12:05:51 2022 -0500 refactor: a few type-checks have a new return type commit f15c5b8 Merge: 19eb450 6915a84 Author: Jude Nelson <judecn@gmail.com> Date: Wed Nov 23 19:37:21 2022 +0000 Merge pull request #3419 from stacks-network/fix/3418 Fix/3418 commit 6915a84 Author: Jude Nelson <judecn@gmail.com> Date: Wed Nov 23 12:36:50 2022 -0500 fix: cargo fmt commit fefad6c Author: Jude Nelson <judecn@gmail.com> Date: Wed Nov 23 10:58:43 2022 -0500 fix: update chain tip hash commit 4831039 Author: Jude Nelson <judecn@gmail.com> Date: Wed Nov 23 10:58:22 2022 -0500 fix: document tie-breaker commit 941c364 Author: Jude Nelson <judecn@gmail.com> Date: Wed Nov 23 09:10:21 2022 -0500 chore: update changelog commit 7c3552a Author: Jude Nelson <judecn@gmail.com> Date: Tue Nov 22 21:29:00 2022 -0500 fix: tie-breaker alters a test's behavior commit 6cda2cc Author: Jude Nelson <judecn@gmail.com> Date: Tue Nov 22 18:24:27 2022 -0500 fix: API sync; add determinstic tie-break for stacks chain tips; clean up compiler warnings commit 817932e Author: Jude Nelson <judecn@gmail.com> Date: Tue Nov 22 17:43:40 2022 -0500 fix: always calculate the highest stacks block pointer in all forks whenever we set a block as processed commit 92fd07d Author: Jude Nelson <judecn@gmail.com> Date: Tue Nov 22 17:43:32 2022 -0500 fix: compiler warnings commit 49e11ac Author: Jude Nelson <judecn@gmail.com> Date: Tue Nov 22 17:43:21 2022 -0500 fix: compiler warning commit 19eb450 Merge: adb0d86 feb873e Author: Jude Nelson <judecn@gmail.com> Date: Mon Nov 21 22:51:47 2022 +0000 Merge pull request #3248 from stacks-network/tip-mine Profiling tools commit feb873e Merge: 2b1be1e adb0d86 Author: igorsyl <1248500+igorsyl@users.noreply.github.com> Date: Fri Nov 18 18:28:27 2022 -0600 Merge branch 'develop' into tip-mine commit adb0d86 Merge: 8d7e864 84d643d Author: Jude Nelson <judecn@gmail.com> Date: Fri Nov 18 14:35:21 2022 +0000 Merge pull request #3406 from stacks-network/fix/3400 Fix/3400 commit 84d643d Author: Jude Nelson <judecn@gmail.com> Date: Thu Nov 17 21:40:15 2022 -0500 fix: fix a regression in how we calculate the new microblock miner chain tip so the cost_so_far gets reset on a new tip commit 5a68f54 Author: Jude Nelson <judecn@gmail.com> Date: Thu Nov 17 10:49:20 2022 -0500 fix: logical bug in new integration test; also run cargo fmt commit 78dd49e Author: Jude Nelson <judecn@gmail.com> Date: Thu Nov 17 10:37:26 2022 -0500 fix: unset the microblock public key hash at the end of fault testing commit 3f10a0e Merge: 2f6248b 8d7e864 Author: Jude Nelson <judecn@gmail.com> Date: Thu Nov 17 09:22:43 2022 -0500 Merge branch 'develop' into fix/3400 commit 8d7e864 Merge: c64044e 5d3be72 Author: Brice Dobry <brice@hiro.so> Date: Thu Nov 17 08:07:54 2022 -0500 Merge pull request #3401 from stacks-network/feat/bootstrap-nodes feat: add bootstrap nodes to /v2/neighbors commit 5d3be72 Author: Brice Dobry <brice@hiro.so> Date: Wed Nov 16 15:48:33 2022 -0500 fix: update unit test for new result commit 2f6248b Author: Jude Nelson <judecn@gmail.com> Date: Wed Nov 16 15:26:39 2022 -0500 chore: add new integration test to CI commit 5e10bd5 Author: Jude Nelson <judecn@gmail.com> Date: Wed Nov 16 15:25:41 2022 -0500 feat: verify that the node can produce invalid blocks but continue to mine valid blocks afterwards (simulating a transient mining bug) commit 8b1fa17 Author: Jude Nelson <judecn@gmail.com> Date: Wed Nov 16 15:25:07 2022 -0500 fix: verify that the canonical tip matches the miner tip, and only mine microblocks if not. They may not match if the miner creates an invalid block for some reason (e.g. due to a bug) commit 86c0913 Author: Jude Nelson <judecn@gmail.com> Date: Wed Nov 16 15:23:58 2022 -0500 fix: push empty epoch receipts if the block was invalid commit e5c7ed5 Author: Jude Nelson <judecn@gmail.com> Date: Wed Nov 16 15:23:26 2022 -0500 fix: an empty epoch receipt means the stacks chainstate block processor encountered an invalid block commit ca23adf Author: Brice Dobry <brice@hiro.so> Date: Wed Nov 16 13:19:12 2022 -0500 feat: add bootstrap nodes to /v2/neighbors Adding the bootstrap nodes to this endpoint will help new nodes discover reliable nodes to boot from. commit c64044e Merge: 9d89725 1ef197a Author: Jude Nelson <judecn@gmail.com> Date: Wed Nov 16 04:33:04 2022 +0000 Merge pull request #3387 from stacks-network/feat/immutable-keychain Feat/immutable keychain commit 1ef197a Author: Jude Nelson <judecn@gmail.com> Date: Mon Nov 14 18:12:33 2022 -0500 fix: fix broken test constants commit 7603790 Merge: e9a9d20 1eb69c2 Author: Jude Nelson <judecn@gmail.com> Date: Sun Nov 13 22:13:12 2022 -0500 Merge branch 'feat/immutable-keychain' of https://github.com/stacks-network/stacks-blockchain into feat/immutable-keychain commit e9a9d20 Author: Jude Nelson <judecn@gmail.com> Date: Sun Nov 13 22:11:46 2022 -0500 fix: In test mode, use the block height's big-endian bytes as the microblock keypair salt. In prod, use the parent index block hash. commit 1eb69c2 Author: Jude Nelson <judecn@gmail.com> Date: Fri Nov 11 14:05:28 2022 -0500 fix: flip test/not-test commit 8a618d2 Author: Jude Nelson <judecn@gmail.com> Date: Fri Nov 11 13:36:16 2022 -0500 fix: address PR feedback commit 189eadf Author: Jude Nelson <judecn@gmail.com> Date: Thu Nov 10 18:10:07 2022 -0500 fix: use the same mocked microblock key salt when we find a private key commit 64838ab Author: Jude Nelson <judecn@gmail.com> Date: Thu Nov 10 18:09:54 2022 -0500 fix: use the right tip hash commit e3a92a9 Author: Jude Nelson <judecn@gmail.com> Date: Thu Nov 10 18:09:45 2022 -0500 chore: API sync commit 2c535e8 Author: Jude Nelson <judecn@gmail.com> Date: Thu Nov 10 18:09:22 2022 -0500 feat: the microblock key salt, outside of tests, is now a function of both the burnchain block height and the parent's index block hash commit f0c66f6 Author: Jude Nelson <judecn@gmail.com> Date: Thu Nov 10 18:09:06 2022 -0500 feat: making a microblock key now takes a salt commit 57e7b94 Author: Jude Nelson <judecn@gmail.com> Date: Thu Nov 10 16:54:03 2022 -0500 fix: API sync, and also, the beginnings of a smoke test for microblock mining commit 10c4afc Author: Jude Nelson <judecn@gmail.com> Date: Thu Nov 10 16:53:08 2022 -0500 fix: remove commented code commit 853e0ff Author: Jude Nelson <judecn@gmail.com> Date: Thu Nov 10 16:52:54 2022 -0500 chore: API sync commit 6c6df6a Author: Jude Nelson <judecn@gmail.com> Date: Thu Nov 10 16:52:35 2022 -0500 chore: use new tip since we changed the VRF key generation code commit 2028ad1 Author: Jude Nelson <judecn@gmail.com> Date: Thu Nov 10 16:52:23 2022 -0500 chore: document RegisteredKey commit 8c2d1d5 Author: Jude Nelson <judecn@gmail.com> Date: Thu Nov 10 16:52:14 2022 -0500 refactor: use the new keychain methods commit 0977fab Author: Jude Nelson <judecn@gmail.com> Date: Thu Nov 10 16:52:03 2022 -0500 refactor: use the new keychain methods commit e843648 Author: Jude Nelson <judecn@gmail.com> Date: Thu Nov 10 16:51:28 2022 -0500 feat: rewrite Keychain so that it's immutable -- all key generation happens with respect to function arguments, not internal state commit 2b1be1e Merge: ff440e5 9d89725 Author: Igor <igor@trustmachines.co> Date: Fri Oct 28 09:17:12 2022 -0500 Merge branch 'develop' of https://github.com/stacks-network/stacks-blockchain into tip-mine commit ff440e5 Author: Igor <igor@trustmachines.co> Date: Thu Oct 20 13:43:12 2022 -0500 rustfmt commit 3ddf88f Merge: d48c5c8 56061ef Author: Igor <igor@trustmachines.co> Date: Thu Oct 20 09:15:22 2022 -0500 Merge branch 'develop' of https://github.com/stacks-network/stacks-blockchain into tip-mine commit d48c5c8 Merge: 577723b 93015f1 Author: igorsyl <1248500+igorsyl@users.noreply.github.com> Date: Tue Oct 18 17:21:57 2022 -0700 Merge branch 'develop' into tip-mine commit 577723b Merge: ee10daa 0a265b7 Author: Jude Nelson <judecn@gmail.com> Date: Mon Oct 17 15:21:45 2022 +0000 Merge branch 'develop' into tip-mine commit ee10daa Merge: a53a575 031a51a Author: igorsyl <1248500+igorsyl@users.noreply.github.com> Date: Mon Oct 10 08:24:58 2022 -0700 Merge branch 'develop' into tip-mine commit a53a575 Author: Igor <igor@trustmachines.co> Date: Sat Oct 1 17:56:30 2022 -0700 rustfmt commit befeb4b Author: Igor <igor@trustmachines.co> Date: Sat Oct 1 17:52:44 2022 -0700 move stacks-events to testnet/stacks-node/src commit f2c7467 Author: Igor <igor@trustmachines.co> Date: Sat Oct 1 12:00:03 2022 -0700 Use pico_args in stacks_events commit 72248e7 Merge: 923b584 07e1df8 Author: igorsyl <1248500+igorsyl@users.noreply.github.com> Date: Sat Oct 1 08:05:34 2022 -0700 Merge branch 'develop' into tip-mine commit 923b584 Author: Igor <igor@trustmachines.co> Date: Thu Aug 25 16:09:01 2022 -0500 updates commit 15dffb2 Author: Igor <igor@trustmachines.co> Date: Thu Aug 25 14:24:16 2022 -0500 updates commit a679c0e Author: Igor <igor@trustmachines.co> Date: Tue Aug 23 15:26:24 2022 -0500 rustfmt commit a004b1c Author: Igor <igor@trustmachines.co> Date: Tue Aug 23 14:18:06 2022 -0500 updates commit 8c9ffc1 Author: Igor <igor@trustmachines.co> Date: Tue Aug 23 14:13:18 2022 -0500 updates commit 6784208 Author: Igor <igor@trustmachines.co> Date: Tue Aug 23 13:40:21 2022 -0500 updates commit 8c757cc Author: Igor <igor@trustmachines.co> Date: Tue Aug 23 13:35:56 2022 -0500 updates commit 3abd38a Author: Igor <igor@trustmachines.co> Date: Tue Aug 23 13:34:53 2022 -0500 updates commit 718ab70 Author: Igor <igor@trustmachines.co> Date: Tue Aug 23 13:32:56 2022 -0500 updates commit c90476a Author: Igor <igor@trustmachines.co> Date: Mon Aug 22 21:20:59 2022 -0500 updates commit a5f8e51 Author: Igor <igor@trustmachines.co> Date: Fri Aug 19 09:00:10 2022 -0500 updates commit 188a218 Author: Igor <igor@trustmachines.co> Date: Fri Aug 19 08:43:31 2022 -0500 updates commit 57c3b16 Author: Igor <igor@trustmachines.co> Date: Fri Aug 12 12:38:57 2022 -0500 updates commit e0b269d Author: Igor <igor@trustmachines.co> Date: Wed Aug 3 17:52:19 2022 -0500 add sql profiling commit 807d74c Author: Igor <igor@trustmachines.co> Date: Wed Aug 17 22:30:05 2022 -0500 updates commit f4ff4a1 Author: Igor <igor@trustmachines.co> Date: Fri Aug 12 22:30:16 2022 -0500 . commit 393567b Author: Igor <igor@trustmachines.co> Date: Fri Aug 12 22:28:45 2022 -0500 . commit 515c9e3 Author: Igor <igor@trustmachines.co> Date: Fri Aug 12 22:30:16 2022 -0500 . commit 546126c Author: Igor <igor@trustmachines.co> Date: Fri Aug 12 22:28:45 2022 -0500 . commit 7912882 Author: Igor <igor@trustmachines.co> Date: Fri Aug 12 12:38:57 2022 -0500 updates commit 36d756e Author: Igor <igor@trustmachines.co> Date: Wed Aug 3 17:55:24 2022 -0500 fix commit 8921a9a Author: Igor <igor@trustmachines.co> Date: Wed Aug 3 17:52:19 2022 -0500 add sql profiling
Adding the bootstrap nodes to this endpoint will help new nodes discover reliable nodes to boot from.