Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chainstate] burnchain_sortition_burn calculation is for the previous, not current sortition #2492

Closed
jcnelson opened this issue Mar 3, 2021 · 2 comments
Closed

[chainstate] burnchain_sortition_burn calculation is for the previous, not current sortition #2492

jcnelson opened this issue Mar 3, 2021 · 2 comments
Assignees
@jcnelson
Labels
stacks-2.1
Projects
Stacks Blockchain Board Stacks 2.1

Comments

@jcnelson
Copy link
Member

jcnelson commented Mar 3, 2021

The burnchain_sortition_burn field in the Stacks headers DB is calculated for sortition N - 1, whereas burnchain_commit_burn is calculated from sortition N. I don't think this field is actually used anywhere anymore, but I'm leery to change/remove it until Stacks 2.1.
@jcnelson jcnelson self-assigned this Mar 3, 2021
@project-bot project-bot bot added this to New Issues in Stacks Blockchain Board Mar 3, 2021
@jcnelson jcnelson mentioned this issue Mar 24, 2021
Closed
@jcnelson jcnelson added this to To do in Stacks 2.1 May 17, 2021
@stale
Copy link

stale bot commented Aug 31, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 31, 2021
@jcnelson jcnelson removed this from To do in Stacks 2.1 Apr 18, 2022
@jcnelson jcnelson added this to To do in Stacks 2.1 via automation May 19, 2022
@jcnelson
Copy link
Member Author

I'm pretty sure this is not consensus-breaking, but it's easy enough to gate if needed. This does need to be fixed for reporting the BTC/STX exchange rate, though.

jcnelson added a commit that referenced this issue May 19, 2022
@jcnelson
fix: fix #2492 by using the burnchain tip's burnchain token spend (wh…
6e6b095 
…ich *shouldn't* affect consensus, since we don't use it anywhere, *but we will need to test it nevertheless!*). Also, plumb through matured miner rewards from block-processing so we can store them
@jcnelson jcnelson mentioned this issue May 19, 2022
Merged
@jcnelson jcnelson moved this from To do to Review in progress in Stacks 2.1 May 23, 2022
@jcnelson jcnelson moved this from Review in progress to Done in Stacks 2.1 Jun 9, 2022
@jcnelson jcnelson closed this as completed Aug 3, 2022
Stacks Blockchain Board automation moved this from New Issues to Done Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcnelson jcnelson

Labels
stacks-2.1
Projects
Stacks 2.1
Done
Stacks Blockchain Board
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@diwakergupta @jcnelson