Fix trait lookup #1817
Merged
Fix trait lookup #1817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
psq
reviewed
Aug 19, 2020
|
will try the code with @friedger examples some time today, but I'm fairly optimistic this will work |
|
I applied the patch and verified it was running fine with the original contracts from @friedger |
psq
reviewed
Aug 19, 2020
| "(define-trait trait-1 ( | ||
| (get-1 (uint) (response uint uint)))) | ||
| (define-public (wrapped-get-1 (contract <trait-1>)) | ||
| (let ((val u0)) |
There was a problem hiding this comment.
perhaps you could add a test with multiple let levels, just to be sure it works in that case as well (it should!)
kantai
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #1815
When optimising for O(1) retrieval in 084ec6e, I should have cascade the fact that the
lookup_callable_contractmethod should be used, instead of accessing the hashmap directly.