feat(Clarity2): Parse and assemble principals #2756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think maybe you need to switch the branch to merge into from |
gregorycoppola
commented
Jul 6, 2021
…cy src/vm, and expand them to cover parsing and constructing contract principals
…to build the tuples returned by principal-parse
|
I'm taking over this PR. |
…tract_name_string_ascii() type signature constructor to represent the type for a contract name in order to implement principal-construct
Codecov Report
@@ Coverage Diff @@
## next #2756 +/- ##
==========================================
+ Coverage 83.75% 83.82% +0.06%
==========================================
Files 265 267 +2
Lines 207954 209960 +2006
==========================================
+ Hits 174166 175993 +1827
- Misses 33788 33967 +179
Continue to review full report at Codecov.
|
|
This PR is now ready for review @kantai @obycode @lgalabru @gregorycoppola @pavitthrap |
kantai
reviewed
Apr 29, 2022
kantai
reviewed
Apr 29, 2022
kantai
reviewed
Apr 29, 2022
kantai
reviewed
Apr 29, 2022
kantai
reviewed
Apr 29, 2022
kantai
reviewed
Apr 29, 2022
kantai
reviewed
Apr 29, 2022
kantai
reviewed
Apr 29, 2022
pavitthrap
reviewed
Apr 29, 2022
…ors, adding an enum for principal-* error codes, renaming principal-parse to principal-destruct, better usage of Value:: helper functions)
obycode
reviewed
May 3, 2022
| @@ -382,7 +391,8 @@ impl DiagnosableError for CheckErrors { | |||
| CheckErrors::MaxContextDepthReached => format!("reached depth limit"), | |||
| CheckErrors::UndefinedVariable(var_name) => format!("use of unresolved variable '{}'", var_name), | |||
| CheckErrors::UndefinedFunction(var_name) => format!("use of unresolved function '{}'", var_name), | |||
| CheckErrors::RequiresAtLeastArguments(expected, found) => format!("expecting >= {} argument, got {}", expected, found), | |||
| CheckErrors::RequiresAtLeastArguments(expected, found) => format!("expecting >= {} arguments, got {}", expected, found), | |||
| CheckErrors::RequiresAtMostArguments(expected, found) => format!("expecting < {} arguments, got {}", expected, found), | |||
There was a problem hiding this comment.
This should say "expecting <=".
kantai
approved these changes
May 4, 2022
jcnelson
approved these changes
May 5, 2022
Stacks Blockchain Board
automation
moved this from Review in progress
to Reviewer approved
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2620
Description
We add two new Clarity2 functions "parse-principal" and "assemble-principal". assemble-principal allows a principal representation to be created from its version and pub_key_hash constituents. parse-principal works in the other direction, parsing a principal representation into its constituent parts.
EDIT(@jcnelson): The functions are now called
principal-parseandprincipal-construct. They allow the caller to both construct standard and contract principals from(buff 1) (buff 20)and(buff 1) (buff 20) (string-ascii 40), respectively, and to parse principal values into values with type{ version: (buff 1), hash-bytes: (buff 20), name: (optional (string-ascii 40)) }. They both returnresponsetypes, and permit the user to parse and construct principals with version bytes that are not currently supported by the consensus rules but are otherwise well-formed by representing them in the(err ..)variant.Testing
See: