feat/remove-pox-sunset #3129
Merged
feat/remove-pox-sunset #3129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #3129 +/- ##
===========================================
- Coverage 83.75% 30.41% -53.35%
===========================================
Files 265 267 +2
Lines 207954 209115 +1161
===========================================
- Hits 174166 63595 -110571
- Misses 33788 145520 +111732
Continue to review full report at Codecov.
|
pavitthrap
approved these changes
May 6, 2022
| @@ -622,20 +591,16 @@ impl LeaderBlockCommitOp { | |||
|
|
|||
| fn check_single_burn_output(&self) -> Result<(), op_error> { | |||
| if self.commit_outs.len() != 1 { | |||
| warn!("Invalid post-sunset block commit, should have 1 commit out"); | |||
| warn!("Invalid block commit, should have 1 commit out"); | |||
There was a problem hiding this comment.
Invalid prepare phase block commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially fixes #2613 by removing the PoX sunset altogether. It does not attempt to gate the PoX sunset code. If we can merge
nexttomasterbefore Bitcoin block 766050 (which is in just over 200 days), then no gating will be needed, since the sunset code will never be reached.This PR does not address capping discount mining, which is the other part of #2613. I'll work on that as a branch off of this branch. I'm just trying to get this fix into
nextASAP.