Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/pox getters #3166

Merged
merged 4 commits into from
Jun 30, 2022
Merged

Feat/pox getters #3166

merged 4 commits into from
Jun 30, 2022

Conversation

jcnelson
Copy link
Member

@jcnelson jcnelson commented Jun 9, 2022

This addresses #2538 by adding getters in .pox-2 for state that is currently invisible. It also adds basic unit tests to verify that the getters work as you'd expect.

@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #3166 (9f10bfb) into next (6376520) will increase coverage by 0.41%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             next    #3166      +/-   ##
==========================================
+ Coverage   83.93%   84.34%   +0.41%     
==========================================
  Files         272      272              
  Lines      213424   213695     +271     
==========================================
+ Hits       179129   180248    +1119     
+ Misses      34295    33447     -848     
Impacted Files Coverage Δ
src/chainstate/stacks/boot/pox_2_tests.rs 93.90% <100.00%> (+1.51%) ⬆️
src/burnchains/bitcoin/network.rs 81.01% <0.00%> (-0.47%) ⬇️
src/util_lib/bloom.rs 92.59% <0.00%> (-0.42%) ⬇️
src/burnchains/bitcoin/spv.rs 76.70% <0.00%> (-0.33%) ⬇️
src/net/poll.rs 62.43% <0.00%> (-0.26%) ⬇️
src/chainstate/coordinator/mod.rs 90.59% <0.00%> (-0.16%) ⬇️
src/net/http.rs 76.90% <0.00%> (-0.09%) ⬇️
src/net/connection.rs 84.03% <0.00%> (-0.07%) ⬇️
src/chainstate/stacks/transaction.rs 96.32% <0.00%> (-0.05%) ⬇️
src/chainstate/stacks/index/storage.rs 81.62% <0.00%> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc54d15...9f10bfb. Read the comment docs.

@pavitthrap
Copy link
Contributor

For the work in #3035, could you make current-pox-reward-cycle and burn-height-to-reward-cycle non private?

Copy link
Member

@kantai kantai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but I agree with @pavitthrap's request for making two currently private methods read-only.

@jcnelson
Copy link
Member Author

Done 👍

@jcnelson jcnelson requested a review from kantai June 29, 2022 17:33
Copy link
Member

@kantai kantai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jcnelson jcnelson merged commit 094286c into next Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants