-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/pox getters #3166
Feat/pox getters #3166
Conversation
Codecov Report
@@ Coverage Diff @@
## next #3166 +/- ##
==========================================
+ Coverage 83.93% 84.34% +0.41%
==========================================
Files 272 272
Lines 213424 213695 +271
==========================================
+ Hits 179129 180248 +1119
+ Misses 34295 33447 -848
Continue to review full report at Codecov.
|
For the work in #3035, could you make |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, but I agree with @pavitthrap's request for making two currently private methods read-only
.
Done 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This addresses #2538 by adding getters in
.pox-2
for state that is currently invisible. It also adds basic unit tests to verify that the getters work as you'd expect.