Feat/bill-tx-fee-before-processing #3233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…coverage to verify that this only happens in 2.1. Also, test all transaction unit tests on each epoch for good measure.
Codecov Report
@@ Coverage Diff @@
## next #3233 +/- ##
==========================================
+ Coverage 83.90% 84.61% +0.70%
==========================================
Files 276 276
Lines 221014 221917 +903
==========================================
+ Hits 185450 187772 +2322
+ Misses 35564 34145 -1419
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
…t caught at runtime (but as a String, since they don't serialize)
…the transaction will not invalidate the block. Add testing for this gate.
…dies in tests; test `contract-call?` within a smart contract for runtime checkerrors
… new fee-handling logic causes this test to pass
…om/stacks-network/stacks-blockchain into feat/bill-fee-before-tx-processing
…e changes materialize when a transaction fails due to an analysis error found at runtime
gregorycoppola
approved these changes
Aug 2, 2022
|
Going to wait until #3234 is approved, so I can merge it into this PR, and then merge both into |
…rors Feat/runtime analysis errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #3213. Transactions in 2.1 will pay their fees before being processed.
Nearly all of this PR is just making it so that all transaction unit tests will run against burn DB instances from each epoch. The new stuff is in
::process_transaction()and the testsprocess_fee_gating()andprocess_fee_gating_sponsored()