-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sBTC] Add stx_address method to PegOutRequestOp #3649
Conversation
@kantai I would be grateful for your attention to this PR given it's one of the last remaining pieces for a working sBTC Alpha. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, but it needs two more kinds of tests:
- A test that uses a test vector (i.e., just a hex encoded bitcoin transaction) as input, with a hard coded expected
stx_address
. - Test coverage for the two error cases
Thank you for the feedback. I have added a test case with the test vector and another one for one of the error cases. I discovered that the other error case was infallible, so I changed the method and return type to reflect that. It would be great if you could have another look @kantai 🙏 |
Codecov Report
@@ Coverage Diff @@
## next #3649 +/- ##
==========================================
+ Coverage 29.36% 31.47% +2.11%
==========================================
Files 309 309
Lines 278266 278468 +202
==========================================
+ Hits 81702 87661 +5959
+ Misses 196564 190807 -5757
... and 91 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
c5068ac
to
5620634
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you @kantai |
This PR adds a
PegOutRequestOp::stx_address()
method to derive the stacks address of an sBTC holder requesting to peg out.Closes #3647