Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix compiler warnings #3852

Merged
merged 4 commits into from Nov 22, 2023

Conversation

bestmike007
Copy link
Contributor

Description

Fix compiler warnings.

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

Signed-off-by: bestmike007 <i@bestmike007.com>
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (29e31cd) 0.04% compared to head (3030820) 29.25%.
Report is 3 commits behind head on develop.

❗ Current head 3030820 differs from pull request most recent head b0f637f. Consider uploading reports for the commit b0f637f to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #3852       +/-   ##
============================================
+ Coverage     0.04%   29.25%   +29.20%     
============================================
  Files          401      315       -86     
  Lines       286816   282789     -4027     
============================================
+ Hits           136    82720    +82584     
+ Misses      286680   200069    -86611     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CLAassistant
Copy link

CLAassistant commented Nov 16, 2023

CLA assistant check
All committers have signed the CLA.

@saralab saralab requested a review from obycode November 21, 2023 15:33
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@obycode
Copy link
Contributor

obycode commented Nov 22, 2023

@bestmike007 something recently changed with the CLA check. Can you agree to that again?

@obycode
Copy link
Contributor

obycode commented Nov 22, 2023

@bestmike007 something recently changed with the CLA check. Can you agree to that again?

Oh, never mind. Looks like it's me that needs to sign.

@obycode obycode merged commit e1c2e9b into stacks-network:develop Nov 22, 2023
1 check passed
@bestmike007 bestmike007 deleted the chore/fix-warnings branch November 22, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants