Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix profile-sqlite for stackslib #3854

Merged
merged 7 commits into from
Nov 19, 2023

Conversation

bestmike007
Copy link
Contributor

Description

This PR is to fix building stackslib with -F profile-sqlite.

image

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

Signed-off-by: bestmike007 <i@bestmike007.com>
@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (a6a75f2) 0.04% compared to head (474cd78) 0.04%.
Report is 1 commits behind head on develop.

Files Patch % Lines
stackslib/src/util_lib/db.rs 0.00% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3854   +/-   ##
========================================
  Coverage     0.04%    0.04%           
========================================
  Files          401      401           
  Lines       286810   286816    +6     
========================================
  Hits           136      136           
- Misses      286674   286680    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jcnelson jcnelson requested a review from jbencin October 9, 2023 17:34
Copy link
Contributor

@jbencin jbencin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@CLAassistant
Copy link

CLAassistant commented Nov 16, 2023

CLA assistant check
All committers have signed the CLA.

@jcnelson
Copy link
Member

Hi @bestmike007, can you re-sign the CLA? Thanks!

@bestmike007
Copy link
Contributor Author

@jcnelson I resigned a few days ago.

@jcnelson jcnelson merged commit f6d59f8 into stacks-network:develop Nov 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants