updating startup scripts #3873
Merged
updating startup scripts #3873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wileyj
added
the
chore
Codecov Report
@@ Coverage Diff @@
## develop #3873 +/- ##
========================================
Coverage 0.16% 0.16%
========================================
Files 337 337
Lines 286759 286759
========================================
Hits 469 469
Misses 286290 286290 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
CharlieC3
approved these changes
Aug 24, 2023
jcnelson
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the
stacks.systemunitfile, stopping the service during when not at chain tip was resulting in a panic (thread stopped).The methods used in the current systemd unit no longer appear to be needed where a PID is recorded via forking the process using
sh.Using a standard execstart line of
ExecStart=/usr/local/bin/stacks-node start --config=/etc/stacks-blockchain/Config.tomlseems more than sufficient now - start/stop/restart all work as expected during a sync as well as when the chain has reached tip.
Minor correction was made in the
stacks.initscript to use the default logfile mentioned in the comment vs a non-existent/stacks-blockchaindirectory (this is configurable by the user).