Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix invalid example in docs #4044

Merged
merged 2 commits into from Nov 21, 2023
Merged

docs: fix invalid example in docs #4044

merged 2 commits into from Nov 21, 2023

Conversation

obycode
Copy link
Contributor

@obycode obycode commented Nov 9, 2023

Description

This just fixes some errors in one of the examples in the docs. No code changes.

Applicable issues

  • N/A

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (049db7e) 0.18% compared to head (37b50d1) 0.06%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4044      +/-   ##
==========================================
- Coverage    0.18%    0.06%   -0.12%     
==========================================
  Files         301      300       -1     
  Lines      277178   276083    -1095     
==========================================
- Hits          512      179     -333     
+ Misses     276666   275904     -762     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CLAassistant
Copy link

CLAassistant commented Nov 16, 2023

CLA assistant check
All committers have signed the CLA.

@obycode obycode merged commit 6d0effc into master Nov 21, 2023
2 checks passed
@obycode obycode deleted the fix/doc-error branch November 21, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants