Improve revoke delegate stx #4157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friedger
force-pushed
the
feat/pox-4-revoke-delegate-stx
branch
from
c068795
to
983a693
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## next #4157 +/- ##
==========================================
- Coverage 83.09% 82.79% -0.31%
==========================================
Files 430 430
Lines 306140 306345 +205
==========================================
- Hits 254382 253631 -751
- Misses 51758 52714 +956 ☔ View full report in Codecov by Sentry. |
2 tasks
friedger
commented
Dec 13, 2023
jcnelson
reviewed
Dec 22, 2023
jcnelson
approved these changes
Dec 22, 2023
setzeus
approved these changes
Dec 23, 2023
friedger
force-pushed
the
feat/pox-4-revoke-delegate-stx
branch
from
b0a7476
to
c360c95
Compare
friedger
changed the base branch from
feat/pox-4-disallow-stacking-during-prepare-phase
to
next
chore: add check for stacking during prepare phase chore: re-add deleted code feat: add revoke-delegate-stx event chore: re-add deleted code feat: add check for delegation state in revoke-delegate-stx chore: move revoke tests to pox-4 chore: add test for revoke event chore: fmt feat: revoke-delegate-stx fails also after expiry fix: use correct type fix: make revoke-delegate-stx event backwards compatible chore: revert unwanted changes chore: remove unwanted changes
friedger
force-pushed
the
feat/pox-4-revoke-delegate-stx
branch
from
33d551d
to
c77969b
Compare
…twork/stacks-core into feat/pox-4-revoke-delegate-stx
kantai
approved these changes
Jan 11, 2024
zone117x
approved these changes
Jan 11, 2024
jcnelson
approved these changes
Jan 11, 2024
janniks
reviewed
Jan 15, 2024
| format!( | ||
| r#" | ||
| {{ | ||
| data: {{ delegate-to: '{delegate_to} }} |
There was a problem hiding this comment.
Should this be delegated-to like in the delegation map in Clarity? cc @friedger
There was a problem hiding this comment.
@janniks I was inspired by the delegate-stx parameter name and the database column of the pox3_events table
But your suggestion makes sense.
There was a problem hiding this comment.
Created new issue #4246
There was a problem hiding this comment.
Yeah, good point. Might make sense in that case to keep named the same. Not sure 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the function
revoke-delegate-stxso that the information which pool the user just left is transparent. The function call would fail if the user is not part of a pool.Furthermore, an event for revoking is synthesized similar to other pox events.
Applicable issues
revoke-delegate-stxcalls should fail if no state is changed #4146Additional info (benefits, drawbacks, caveats)
Checklist
docs/rpc/openapi.yamlandrpc-endpoints.mdfor v2 endpoints,event-dispatcher.mdfor new events)clarity-benchmarkingrepobitcoin-tests.yml