Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use pull_request to trigger ci runs #4161

Merged
merged 1 commit into from
Dec 12, 2023
Merged

use pull_request to trigger ci runs #4161

merged 1 commit into from
Dec 12, 2023

Conversation

wileyj
Copy link
Contributor

@wileyj wileyj commented Dec 12, 2023

this is a minor fix in how the CI triggers due to issues noticed downstream in next.
pull_request_target is not working the way that was expected, in that it is building against the target branch, and not the base branch.
this commit fixes that.

once merged, a second PR from develop-> next will be opened.

this is also addressed in master in #4160

@wileyj wileyj added bug Unwanted or unintended property causing functional harm CI labels Dec 12, 2023
@wileyj wileyj self-assigned this Dec 12, 2023
@wileyj wileyj merged commit 9fe5950 into develop Dec 12, 2023
1 check passed
@wileyj wileyj deleted the ci/fix-pr-target branch December 12, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unwanted or unintended property causing functional harm CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants