Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fee estimate #4224

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Fix fee estimate #4224

merged 2 commits into from
Jan 4, 2024

Conversation

obycode
Copy link
Contributor

@obycode obycode commented Jan 1, 2024

No description provided.

Copy link

codecov bot commented Jan 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a7e9237) 77.47% compared to head (2d7f9ed) 82.49%.
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4224      +/-   ##
===========================================
+ Coverage    77.47%   82.49%   +5.01%     
===========================================
  Files          401      401              
  Lines       286385   286385              
===========================================
+ Hits        221883   236252   +14369     
+ Misses       64502    50133   -14369     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AshtonStephens
Copy link
Collaborator

While you're in here can you change the fee estimates to be for the fastest version and not the 30 minute version?

# Fee estimation API URLS and their corresponding fee extraction functions.
FEE_ESTIMATIONS = [
    # Bitcoiner Live API
    (
        'https://bitcoiner.live/api/fees/estimates/latest',
        lambda response_json: response_json["estimates"]["30"]["sat_per_vbyte"],
    ),

    # Mempool Space API
    (
        'https://mempool.space/api/v1/fees/recommended',
        lambda response_json: response_json["fastestFee"],
    ),

    # Blockchain.info API
    (
        'https://api.blockchain.info/mempool/fees',
        lambda response_json: response_json["priority"],
    ),
]

@obycode
Copy link
Contributor Author

obycode commented Jan 2, 2024

While you're in here can you change the fee estimates to be for the fastest version and not the 30 minute version?

You're talking about the bitcoiner.live API, right? Looking at the output, it looks like 30 is the fastest option. It returns 30, 60, 120, 180, 360, 720, and 1440.

@obycode
Copy link
Contributor Author

obycode commented Jan 2, 2024

While you're in here can you change the fee estimates to be for the fastest version and not the 30 minute version?

You're talking about the bitcoiner.live API, right? Looking at the output, it looks like 30 is the fastest option. It returns 30, 60, 120, 180, 360, 720, and 1440.

Oh, I see I can bump the confidence level up to 90% with ?confidence=0.9. The value that returns for 30 minutes is the best we'll get I think.

@obycode obycode merged commit 8a075a0 into develop Jan 4, 2024
2 checks passed
@obycode obycode deleted the fix/fee-estimate branch January 4, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants