Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master to develop #4251

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Conversation

jcnelson
Copy link
Member

See title

Copy link
Member

@kantai kantai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as CI passes

Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 1671 lines in your changes are missing coverage. Please review.

Comparison is base (e6dac0a) 82.60% compared to head (9012cf7) 52.94%.

Files Patch % Lines
testnet/stacks-node/src/chain_data.rs 18.15% 726 Missing ⚠️
testnet/stacks-node/src/neon_node.rs 67.72% 233 Missing ⚠️
testnet/stacks-node/src/tests/neon_integrations.rs 30.64% 215 Missing ⚠️
testnet/stacks-node/src/main.rs 0.00% 197 Missing ⚠️
testnet/stacks-node/src/tests/mod.rs 39.36% 191 Missing ⚠️
testnet/stacks-node/src/config.rs 38.20% 55 Missing ⚠️
stackslib/src/core/mempool.rs 73.33% 20 Missing ⚠️
...-node/src/burnchains/bitcoin_regtest_controller.rs 43.33% 17 Missing ⚠️
stackslib/src/core/tests/mod.rs 90.06% 16 Missing ⚠️
stackslib/src/net/rpc.rs 90.90% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #4251       +/-   ##
============================================
- Coverage    82.60%   52.94%   -29.66%     
============================================
  Files          401      402        +1     
  Lines       288404   291084     +2680     
============================================
- Hits        238242   154127    -84115     
- Misses       50162   136957    +86795     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jcnelson jcnelson mentioned this pull request Jan 17, 2024
@jcnelson jcnelson merged commit 4b6638a into develop Jan 17, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants