Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add an endpoint for listing which nodes host a stackerdb replica #4270

Merged
merged 1 commit into from Jan 23, 2024

Conversation

jcnelson
Copy link
Member

Got one quick PR for the upcoming 2.4.0.1.0 release -- the ability to ask a node for the list of nodes it knows replicate a given StackerDB. If a user adds a StackerDB replica to their node, they can assess how quickly other (public) nodes learn of it.

…endpoint, which returns a list of recently-seen neighbor addresses which replicate a particular StackerDB
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (71355c5) 82.29% compared to head (ff7c549) 76.50%.
Report is 1 commits behind head on release/2.5.0.1.0.

Files Patch % Lines
stackslib/src/net/api/liststackerdbreplicas.rs 89.52% 11 Missing ⚠️
...ackslib/src/net/api/tests/liststackerdbreplicas.rs 95.34% 4 Missing ⚠️
stackslib/src/net/stackerdb/sync.rs 50.00% 2 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/2.5.0.1.0    #4270      +/-   ##
=====================================================
- Coverage              82.29%   76.50%   -5.79%     
=====================================================
  Files                    402      404       +2     
  Lines                 292005   292281     +276     
=====================================================
- Hits                  240295   223614   -16681     
- Misses                 51710    68667   +16957     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@obycode
Copy link
Contributor

obycode commented Jan 22, 2024

Is this supposed to be merging into release/2.5.0.1.0?

@jcnelson
Copy link
Member Author

The branch name has a typo. That's supposed to be 2.4.0.1.0

Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@jferrant jferrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@jcnelson jcnelson merged commit f747b00 into release/2.5.0.1.0 Jan 23, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants