Feat/signers write transactions to stackerdb

[jferrant]

Description

Signers must broadcast their cast aggregate public key transaction to the mempool if in pre nakamoto rules, and always broadcast the transaction to stackerdb for signers and miners to observe when validating and building the block, respectively.

Applicable issues

• fixes #[Nakamoto] Stacks-signer should write a list of all their transactions to stackerdb rather than to the mempool #4006

For this to be fully tested, we need to have the cast aggregate public key transaction happening

[codecov]

Codecov Report

Attention: 342 lines in your changes are missing coverage. Please review.

Comparison is base (dd006d4) 82.86% compared to head (fc7149b) 59.46%.

Files	Patch %	Lines
stacks-signer/src/runloop.rs	66.36%	148 Missing ⚠️
stacks-signer/src/client/stacks_client.rs	63.92%	127 Missing ⚠️
stacks-signer/src/client/stackerdb.rs	67.17%	43 Missing ⚠️
libsigner/src/messages.rs	94.01%	7 Missing ⚠️
stacks-signer/src/utils.rs	72.72%	6 Missing ⚠️
testnet/stacks-node/src/tests/signer.rs	97.05%	5 Missing ⚠️
stacks-signer/src/config.rs	80.95%	4 Missing ⚠️
stacks-signer/src/main.rs	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             next    #4301       +/-   ##
===========================================
- Coverage   82.86%   59.46%   -23.40%     
===========================================
  Files         443      443               
  Lines      315904   316885      +981     
===========================================
- Hits       261769   188448    -73321     
- Misses      54135   128437    +74302     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jcnelson]

What happens if chunk_ack.len() >= signer_ids.len()?

[jferrant]

This cannot happen. The call get_latest_chunks will just return None for slots that don't exist so we will always return as many chunks as we queried. and we query an equal number of slots to signer_ids.If this was to happen, it would be a BUG in the system hence the expect.

[kantai]

This LGTM, just a few superficial comments.

[jcnelson]

LGTM; just address Aaron's comments before merging and make sure CI is passing.