Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Vote Print Statement #4324

Merged
merged 4 commits into from
Feb 2, 2024
Merged

Updated Vote Print Statement #4324

merged 4 commits into from
Feb 2, 2024

Conversation

setzeus
Copy link
Collaborator

@setzeus setzeus commented Feb 1, 2024

As discussed during Un/block meeting, the simplest/fastest solution for #4231 is simply to update the print statement found in 'vote-for-aggregate-public-key.'

The node will then take this information & then check whether the consensus threshold was met / a new aggregate public key has been submitted.

Since this is a simple print statement update there are no additional test to write.

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5c14a44) 82.01% compared to head (339829f) 59.27%.
Report is 5 commits behind head on next.

Additional details and impacted files
@@             Coverage Diff             @@
##             next    #4324       +/-   ##
===========================================
- Coverage   82.01%   59.27%   -22.74%     
===========================================
  Files         435      435               
  Lines      309278   309278               
===========================================
- Hits       253652   183334    -70318     
- Misses      55626   125944    +70318     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@setzeus setzeus marked this pull request as ready for review February 1, 2024 16:44
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@saralab saralab merged commit c9f3fb2 into next Feb 2, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants