Feat: trigger stackerdb refresh when .signers is written #4330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kantai
force-pushed
the
feat/signer-trigger-stackerdb
branch
from
6d8a952
to
fb9c54d
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## next #4330 +/- ##
===========================================
+ Coverage 61.25% 76.99% +15.74%
===========================================
Files 445 445
Lines 317161 317217 +56
===========================================
+ Hits 194276 244247 +49971
+ Misses 122885 72970 -49915 ☔ View full report in Codecov by Sentry. |
kantai
force-pushed
the
feat/signer-trigger-stackerdb
branch
from
3587e2b
to
fb9c54d
Compare
jcnelson
reviewed
Feb 2, 2024
| @@ -202,6 +202,21 @@ impl PeerThread { | |||
| } | |||
| } | |||
|
|
|||
| fn check_stackerdb_reload(&mut self) { | |||
There was a problem hiding this comment.
Minor nit: This is doing a check and then maybe doing some work based on that check. Maybe this should be called stackerdb_refresh() or something?
jferrant
approved these changes
Feb 3, 2024
|
Thank you for doing this! |
|
Having a really hard time rebasing on this XD (couldn't cherry pick it out) |
kantai
force-pushed
the
feat/larger-stackerdb
branch
from
40be4b6
to
1f9b184
Compare
kantai
force-pushed
the
feat/signer-trigger-stackerdb
branch
from
fb9c54d
to
645a931
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This implements #4328 by adding a signaling bool to the coordinator channels structs. It's a bit cludgier than I would otherwise want, but I think it's the best we can do without majorly refactoring the coordinator's signatures (which is probably a good idea, but one best left to the future).
This is a draft for now, because it depends on
feat/larger-stackerdb, but it could be cherry-picked/rebased tonextinstead.