feat: burn op definition and storage for vote-for-agg-key #4376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ash, not the reward cycle consensus hash
…ash, not the reward cycle consensus hash
…aleView if the rc_consensus_hash doesn't match
…asn't completed a full state-machine pass yet
…ut it will once its view converges
…e p2p network needs it to exist
Hotfix/stackerdb stale view
…move that outer error before acting on a blanket `Ok(_)` / `Err(_)` match
Hotfix/masked result
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #4376 +/- ##
==========================================
+ Coverage 83.22% 83.28% +0.05%
==========================================
Files 452 453 +1
Lines 326058 327328 +1270
Branches 323 323
==========================================
+ Hits 271359 272610 +1251
- Misses 54691 54710 +19
Partials 8 8
... and 18 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
[CI] fix error in release step that generates checksums
8marz8
reviewed
Feb 14, 2024
obycode
force-pushed
the
feat/4354-aggregate-key
branch
from
2f453de
to
018ea78
Compare
hstove
force-pushed
the
feat/vote-for-key-burnop
branch
from
3d5adf5
to
11e5170
Compare
obycode
reviewed
Feb 28, 2024
obycode
reviewed
Feb 28, 2024
8marz8
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on my notes in this discussion, this PR implements a burn op for
vote-for-aggregate-key.This PR is currently a work in progress. The code exists for parsing and storing this new burn op, but I've yet to actually process the burn op by making a Clarity tx.
This is built on top of #4360, because that PR has the updated function signature for
vote-for-aggregate-public-key.