Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove imports already included by std::prelude #4390

Merged
merged 1 commit into from Feb 28, 2024

Conversation

jbencin
Copy link
Contributor

@jbencin jbencin commented Feb 17, 2024

Description

Remove all imports already included by std::prelude as of Rust Edition 2021. Deletes about 150 lines from the codebase

Additional info (benefits, drawbacks, caveats)

This PR does nothing other than remove use statements. Since the binaries and tests still build, it's obviously safe to merge

Copy link

codecov bot commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.37%. Comparing base (9385b42) to head (76268b4).

Additional details and impacted files
@@             Coverage Diff             @@
##             next    #4390       +/-   ##
===========================================
- Coverage   83.41%   66.37%   -17.04%     
===========================================
  Files         448      448               
  Lines      323930   323930               
===========================================
- Hits       270197   215016    -55181     
- Misses      53733   108914    +55181     
Files Coverage Δ
clarity/src/libclarity.rs 39.28% <ø> (ø)
clarity/src/vm/analysis/type_checker/v2_05/mod.rs 89.85% <ø> (-1.00%) ⬇️
.../src/vm/analysis/type_checker/v2_05/natives/mod.rs 90.90% <ø> (-0.53%) ⬇️
...m/analysis/type_checker/v2_05/natives/sequences.rs 93.98% <ø> (-0.38%) ⬇️
...src/vm/analysis/type_checker/v2_05/tests/assets.rs 0.00% <ø> (-100.00%) ⬇️
...ty/src/vm/analysis/type_checker/v2_05/tests/mod.rs 65.93% <ø> (-33.98%) ⬇️
clarity/src/vm/analysis/type_checker/v2_1/mod.rs 89.00% <ø> (-0.70%) ⬇️
...y/src/vm/analysis/type_checker/v2_1/natives/mod.rs 90.47% <ø> (-0.67%) ⬇️
...vm/analysis/type_checker/v2_1/natives/sequences.rs 93.97% <ø> (-1.68%) ⬇️
.../src/vm/analysis/type_checker/v2_1/tests/assets.rs 100.00% <ø> (ø)
... and 104 more

... and 184 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9385b42...76268b4. Read the comment docs.

jferrant
jferrant previously approved these changes Feb 26, 2024
cylewitruk
cylewitruk previously approved these changes Feb 26, 2024
Copy link
Member

@cylewitruk cylewitruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only use statements updated, lgtm 👍

@jbencin jbencin dismissed stale reviews from cylewitruk and jferrant via af76742 February 27, 2024 19:03
@jbencin jbencin force-pushed the chore/remove-prelude-imports branch 2 times, most recently from af76742 to efafc49 Compare February 27, 2024 19:09
Copy link
Member

@cylewitruk cylewitruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as before, only use statements updated -- lgtm :)

@jbencin jbencin merged commit 3c8d656 into stacks-network:next Feb 28, 2024
1 of 2 checks passed
@jbencin jbencin deleted the chore/remove-prelude-imports branch February 28, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants