New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove imports already included by std::prelude
#4390
chore: Remove imports already included by std::prelude
#4390
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #4390 +/- ##
===========================================
- Coverage 83.41% 66.37% -17.04%
===========================================
Files 448 448
Lines 323930 323930
===========================================
- Hits 270197 215016 -55181
- Misses 53733 108914 +55181
... and 184 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only use
statements updated, lgtm 👍
af76742
to
efafc49
Compare
efafc49
to
76268b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as before, only use statements updated -- lgtm :)
Description
Remove all imports already included by
std::prelude
as of Rust Edition 2021. Deletes about 150 lines from the codebaseAdditional info (benefits, drawbacks, caveats)
This PR does nothing other than remove
use
statements. Since the binaries and tests still build, it's obviously safe to merge