Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including rewardSet in new block event #4430

Merged
merged 7 commits into from Mar 7, 2024
Merged

Conversation

8marz8
Copy link
Contributor

@8marz8 8marz8 commented Feb 27, 2024

Description

This PR includes RewardSet data in new_block events instead of broadcasting a separate event.

Note: This Draft PR is not completed and only has the initial tweaks to confirm the approach.

Applicable issues

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 87.40741% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 77.62%. Comparing base (04e5eb2) to head (242264e).
Report is 4 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #4430      +/-   ##
==========================================
- Coverage   83.23%   77.62%   -5.62%     
==========================================
  Files         451      451              
  Lines      325724   325766      +42     
  Branches      323      323              
==========================================
- Hits       271125   252875   -18250     
- Misses      54591    72883   +18292     
  Partials        8        8              
Files Coverage Δ
stackslib/src/chainstate/coordinator/mod.rs 61.53% <ø> (-0.05%) ⬇️
stackslib/src/net/mod.rs 72.87% <100.00%> (-0.17%) ⬇️
testnet/stacks-node/src/config.rs 56.53% <ø> (-7.22%) ⬇️
testnet/stacks-node/src/event_dispatcher.rs 83.00% <100.00%> (-2.76%) ⬇️
testnet/stacks-node/src/run_loop/mod.rs 99.18% <100.00%> (+<0.01%) ⬆️
stackslib/src/chainstate/coordinator/tests.rs 84.70% <0.00%> (-6.00%) ⬇️
stackslib/src/chainstate/stacks/boot/mod.rs 90.58% <85.71%> (-4.18%) ⬇️
stackslib/src/main.rs 0.06% <0.00%> (ø)
stackslib/src/chainstate/stacks/db/blocks.rs 85.14% <93.93%> (-4.78%) ⬇️
stackslib/src/chainstate/nakamoto/mod.rs 83.13% <80.00%> (-0.32%) ⬇️
... and 1 more

... and 159 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04e5eb2...242264e. Read the comment docs.

@8marz8 8marz8 changed the title Initial changes for including rewardSet in new block event Including rewardSet in new block event Feb 28, 2024
Copy link
Member

@zone117x zone117x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far this is working great! I'm getting the reward info in the /new_block event, and it's worked for several cycles so far in testing.

@saralab saralab marked this pull request as ready for review March 7, 2024 14:54
Copy link
Member

@kantai kantai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kantai kantai added this pull request to the merge queue Mar 7, 2024
Merged via the queue into next with commit cab1a11 Mar 7, 2024
1 of 2 checks passed
@8marz8 8marz8 deleted the feat/expand-new-block-event branch April 8, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants