New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Including rewardSet in new block event #4430
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #4430 +/- ##
==========================================
- Coverage 83.23% 77.62% -5.62%
==========================================
Files 451 451
Lines 325724 325766 +42
Branches 323 323
==========================================
- Hits 271125 252875 -18250
- Misses 54591 72883 +18292
Partials 8 8
... and 159 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…based on block events
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far this is working great! I'm getting the reward info in the /new_block
event, and it's worked for several cycles so far in testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This PR includes RewardSet data in new_block events instead of broadcasting a separate event.
Note: This Draft PR is not completed and only has the initial tweaks to confirm the approach.
Applicable issues
/new_pox_set
event data into/new_block
event #4407