Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ci trigger to enable merge queue in next #4438

Merged
merged 4 commits into from Feb 28, 2024
Merged

Update ci trigger to enable merge queue in next #4438

merged 4 commits into from Feb 28, 2024

Conversation

wileyj
Copy link
Contributor

@wileyj wileyj commented Feb 27, 2024

Adds a secondary trigger when merge queues are enabled for required status checks to complete when a PR is added to the merge queue.

to test, i created a sample protected branch next-mq and replicated the status checks from next with merge queue enabled and then created a new branch based off of next-mq to test a PR:

PR: #4429
merge queue (is empty, but will show statistic of 1 merged PR): https://github.com/stacks-network/stacks-core/queue/next-mq
merge queue status check run: https://github.com/stacks-network/stacks-core/actions/runs/8056854227

This change was in response to a previous PR that failed status checks in the merge queue: #4287 necessitating this change here. the problem encountered with 4287 was that the caches weren't being created, which the required tests (unit-tests etc) relied on. this commit will create those caches when a PR i added to the merge group.

Once this is merged, merge queues can be re-enabled for next

@wileyj wileyj added enhancement Iterations on existing features or infrastructure. CI labels Feb 27, 2024
@wileyj wileyj self-assigned this Feb 27, 2024
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@wileyj wileyj requested a review from ASuciuX February 28, 2024 17:19
@wileyj wileyj requested a review from ASuciuX February 28, 2024 17:22
@wileyj wileyj merged commit 5e25501 into next Feb 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI enhancement Iterations on existing features or infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants