Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix signer nonces #4480

Merged
merged 1 commit into from Mar 4, 2024
Merged

Fix signer nonces #4480

merged 1 commit into from Mar 4, 2024

Conversation

obycode
Copy link
Contributor

@obycode obycode commented Mar 4, 2024

Use the latest tip when retrieving the nonces for the singers to filter transactions from the stackerdb.

@obycode obycode requested review from hstove and jferrant March 4, 2024 17:33
Copy link
Collaborator

@xoloki xoloki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.62%. Comparing base (0910eed) to head (2493821).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #4480      +/-   ##
==========================================
- Coverage   83.17%   77.62%   -5.56%     
==========================================
  Files         453      453              
  Lines      325584   325588       +4     
  Branches      318      318              
==========================================
- Hits       270816   252731   -18085     
- Misses      54760    72849   +18089     
  Partials        8        8              
Files Coverage Δ
testnet/stacks-node/src/nakamoto_node/miner.rs 82.20% <100.00%> (+0.09%) ⬆️

... and 165 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0910eed...2493821. Read the comment docs.

@obycode obycode enabled auto-merge March 4, 2024 18:54
@obycode obycode added this pull request to the merge queue Mar 4, 2024
Merged via the queue into next with commit 5f88734 Mar 4, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants