Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If data already exists in a stackerdb slot, update version number #4507

Merged
merged 1 commit into from Mar 8, 2024

Conversation

jferrant
Copy link
Collaborator

@jferrant jferrant commented Mar 8, 2024

Improvement to our version number logic. Do not increment by one. Just immediately update to one past the last seen version number.

Applicable issues

Closes #4506

Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 71.92%. Comparing base (206ea63) to head (60c6abc).

Additional details and impacted files
@@             Coverage Diff             @@
##             next    #4507       +/-   ##
===========================================
- Coverage   83.24%   71.92%   -11.32%     
===========================================
  Files         452      452               
  Lines      326005   326008        +3     
  Branches      323      323               
===========================================
- Hits       271372   234492    -36880     
- Misses      54625    91508    +36883     
  Partials        8        8               
Files Coverage Δ
stacks-signer/src/client/stackerdb.rs 89.79% <80.00%> (-0.29%) ⬇️

... and 214 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 206ea63...60c6abc. Read the comment docs.

@jferrant jferrant added this pull request to the merge queue Mar 8, 2024
Merged via the queue into next with commit 078a984 Mar 8, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants