Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include signer bitvec in nakamoto block event #4526

Merged
merged 2 commits into from Mar 13, 2024

Conversation

hstove
Copy link
Contributor

@hstove hstove commented Mar 12, 2024

This includes the signer_bitvec in the /mined_nakamoto_block event.

This property is formatted as a hex string, using the consensus_serialize implementation of BitVec. The first bytes are the length of the bitvec, encoded as a u16. Then the rest of the string is the bitvec data.

@hstove hstove linked an issue Mar 12, 2024 that may be closed by this pull request
zone117x

This comment was marked as outdated.

Copy link
Member

@zone117x zone117x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL about the /mined_nakamoto_block. This one isn't consumed anywhere AFAIK (and first time I've seen it). Could you please add this to the /new_block event?

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 68.18182% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 72.60%. Comparing base (ae8a483) to head (a5e6550).
Report is 49 commits behind head on next.

Additional details and impacted files
@@             Coverage Diff             @@
##             next    #4526       +/-   ##
===========================================
- Coverage   83.30%   72.60%   -10.70%     
===========================================
  Files         452      453        +1     
  Lines      326058   327384     +1326     
  Branches      323      323               
===========================================
- Hits       271614   237707    -33907     
- Misses      54436    89669    +35233     
  Partials        8        8               
Files Coverage Δ
stackslib/src/chainstate/coordinator/mod.rs 61.53% <ø> (+0.21%) ⬆️
stackslib/src/chainstate/nakamoto/mod.rs 83.27% <100.00%> (-0.14%) ⬇️
stackslib/src/net/mod.rs 69.43% <100.00%> (-3.84%) ⬇️
testnet/stacks-node/src/run_loop/mod.rs 99.18% <100.00%> (+<0.01%) ⬆️
...net/stacks-node/src/tests/nakamoto_integrations.rs 95.26% <100.00%> (+0.30%) ⬆️
stackslib/src/chainstate/coordinator/tests.rs 76.33% <0.00%> (-14.46%) ⬇️
stackslib/src/chainstate/stacks/db/blocks.rs 79.88% <0.00%> (-10.16%) ⬇️
testnet/stacks-node/src/event_dispatcher.rs 78.03% <62.06%> (-7.37%) ⬇️

... and 215 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae8a483...a5e6550. Read the comment docs.

obycode
obycode previously approved these changes Mar 12, 2024
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@hstove hstove requested a review from zone117x March 13, 2024 15:02
@hstove
Copy link
Contributor Author

hstove commented Mar 13, 2024

@zone117x I've added the bitvec string to /new_block, mind taking another look?

@hstove hstove added this pull request to the merge queue Mar 13, 2024
Merged via the queue into next with commit 616d33c Mar 13, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Nakamoto] Emit signer performance data
5 participants