New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: include signer bitvec in nakamoto block event #4526
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL about the /mined_nakamoto_block
. This one isn't consumed anywhere AFAIK (and first time I've seen it). Could you please add this to the /new_block
event?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #4526 +/- ##
===========================================
- Coverage 83.30% 72.60% -10.70%
===========================================
Files 452 453 +1
Lines 326058 327384 +1326
Branches 323 323
===========================================
- Hits 271614 237707 -33907
- Misses 54436 89669 +35233
Partials 8 8
... and 215 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
@zone117x I've added the bitvec string to |
This includes the
signer_bitvec
in the/mined_nakamoto_block
event.This property is formatted as a hex string, using the
consensus_serialize
implementation of BitVec. The first bytes are the length of the bitvec, encoded as au16
. Then the rest of the string is the bitvec data.