Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace u32::max_value() with u32::MAX #4529

Merged
merged 2 commits into from Mar 13, 2024

Conversation

va-an
Copy link
Contributor

@va-an va-an commented Mar 13, 2024

Description

  • use MAX instead of max_value() for numeric types
  • update repo url for CONTRIBUTING.md

Applicable issues

@CLAassistant
Copy link

CLAassistant commented Mar 13, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@jcnelson jcnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @va-an!

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 41.89189% with 43 lines in your changes are missing coverage. Please review.

Project coverage is 81.21%. Comparing base (2c2afbc) to head (b3a5071).
Report is 5 commits behind head on develop.

Files Patch % Lines
testnet/stacks-node/src/tests/epoch_21.rs 0.00% 17 Missing ⚠️
testnet/stacks-node/src/tests/epoch_22.rs 0.00% 8 Missing ⚠️
testnet/stacks-node/src/tests/epoch_24.rs 0.00% 8 Missing ⚠️
testnet/stacks-node/src/tests/epoch_23.rs 0.00% 4 Missing ⚠️
testnet/stacks-node/src/tests/neon_integrations.rs 86.66% 4 Missing ⚠️
testnet/stacks-node/src/tests/epoch_205.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4529      +/-   ##
===========================================
- Coverage    82.33%   81.21%   -1.13%     
===========================================
  Files          404      404              
  Lines       292642   293057     +415     
===========================================
- Hits        240958   238009    -2949     
- Misses       51684    55048    +3364     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@obycode obycode merged commit 0ccffa8 into stacks-network:develop Mar 13, 2024
1 of 2 checks passed
@va-an
Copy link
Contributor Author

va-an commented Mar 14, 2024

Thanks for merging, @obycode !
Сan we close #3682 now? Or this it something like reminder-ticket?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants