Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add wsts::Point validation to vote-for-aggregate-key burn op #4536

Merged
merged 1 commit into from Mar 13, 2024

Conversation

hstove
Copy link
Contributor

@hstove hstove commented Mar 13, 2024

As noted in #4533, the vote-for-aggregate-key's check method doesn't validate the aggregate key used in the payload against wsts::Point, which can lead to issues if there are any discrepancies between Secp256k1PublicKey and Point. This PR adds validation against Point, along with the existing Secp256k1PublicKey check.

@hstove hstove linked an issue Mar 13, 2024 that may be closed by this pull request
@hstove hstove requested review from xoloki and jcnelson March 13, 2024 15:49
Copy link
Member

@jcnelson jcnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hstove for the quick turn-around on this!

Copy link
Collaborator

@xoloki xoloki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 82.91%. Comparing base (fec1cb5) to head (6b01281).
Report is 5 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #4536      +/-   ##
==========================================
- Coverage   83.16%   82.91%   -0.25%     
==========================================
  Files         453      453              
  Lines      327368   327398      +30     
  Branches      323      323              
==========================================
- Hits       272244   271457     -787     
- Misses      55116    55933     +817     
  Partials        8        8              
Files Coverage Δ
...ainstate/burn/operations/vote_for_aggregate_key.rs 92.74% <93.75%> (+0.06%) ⬆️

... and 37 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fec1cb5...6b01281. Read the comment docs.

@hstove hstove added this pull request to the merge queue Mar 13, 2024
Merged via the queue into next with commit 53173e5 Mar 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] VoteForAggregateKeyOp incorrectly validates aggregate public key
3 participants