Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add affirmation overrides config option and add default xenon ones ne… #4560

Merged
merged 7 commits into from Mar 21, 2024

Conversation

jferrant
Copy link
Collaborator

Closes: #4493

@jferrant jferrant requested a review from wileyj March 19, 2024 19:37
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 94.91525% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 82.05%. Comparing base (284945b) to head (7f399b6).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #4560      +/-   ##
==========================================
- Coverage   83.26%   82.05%   -1.21%     
==========================================
  Files         456      456              
  Lines      330480   330593     +113     
  Branches      323      323              
==========================================
- Hits       275187   271281    -3906     
- Misses      55285    59304    +4019     
  Partials        8        8              
Files Coverage Δ
testnet/stacks-node/src/config.rs 66.02% <100.00%> (+2.02%) ⬆️
stackslib/src/burnchains/db.rs 80.50% <0.00%> (-0.16%) ⬇️
testnet/stacks-node/src/run_loop/neon.rs 82.78% <66.66%> (-1.39%) ⬇️

... and 54 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 284945b...7f399b6. Read the comment docs.

jcnelson
jcnelson previously approved these changes Mar 20, 2024
Copy link
Member

@jcnelson jcnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; just one minor nit

@jferrant jferrant marked this pull request as ready for review March 20, 2024 15:25
wileyj
wileyj previously approved these changes Mar 20, 2024
Copy link
Contributor

@wileyj wileyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit!

@saralab saralab added the 2.5 label Mar 21, 2024
jcnelson
jcnelson previously approved these changes Mar 21, 2024
…cessary to sync from genesis

Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
…for xenon

Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
@jferrant jferrant dismissed stale reviews from jcnelson and wileyj via 7f399b6 March 21, 2024 15:54
@jferrant jferrant force-pushed the feat/add-override-affirmations-to-config branch from 08397d2 to 7f399b6 Compare March 21, 2024 15:54
@jferrant jferrant requested a review from jcnelson March 21, 2024 15:54
@wileyj wileyj enabled auto-merge March 21, 2024 15:55
@wileyj wileyj added this pull request to the merge queue Mar 21, 2024
Merged via the queue into next with commit d2649ff Mar 21, 2024
2 checks passed
ASuciuX added a commit to ASuciuX/stacks-core that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants