New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add flag to output signer key signature in JSON #4580
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #4580 +/- ##
==========================================
- Coverage 83.35% 77.83% -5.53%
==========================================
Files 470 470
Lines 332256 332271 +15
Branches 317 317
==========================================
- Hits 276953 258616 -18337
- Misses 55295 73647 +18352
Partials 8 8
... and 192 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
This PR adds a new (optional) flag,
--json
, to thegenerate-stacking-signature
command instacks-signer
. If specified, the CLI will output all the relevant information in JSON form.The utility of this JSON is that Stacking apps can add a simple "paste JSON" field, which then auto-fills the relevant fields. Because there is a lot of information that must be shared between the signer and stacker, providing this "standard" can help reduce mistakes.
This "paste JSON" functionality is also already implemented in a beta version of Lockstacks: