Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add release-lite profile for low-RAM environments #4599

Merged
merged 2 commits into from Apr 2, 2024

Conversation

jbencin
Copy link
Contributor

@jbencin jbencin commented Mar 27, 2024

Description

Add release-lite profile, which should build faster and take less RAM

Applicable issues

Additional info (benefits, drawbacks, caveats)

Also fixes the code blocks in the README. The $ characters at beginning of each line were unnecessary and interfered with syntax highlighting and copy/pasting

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.75%. Comparing base (2686009) to head (cf4fab4).
Report is 5 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #4599      +/-   ##
==========================================
- Coverage   83.46%   77.75%   -5.71%     
==========================================
  Files         470      470              
  Lines      332151   332151              
  Branches      317      317              
==========================================
- Hits       277220   258256   -18964     
- Misses      54923    73887   +18964     
  Partials        8        8              

see 173 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2686009...cf4fab4. Read the comment docs.

README.md Outdated Show resolved Hide resolved
@wileyj
Copy link
Contributor

wileyj commented Mar 28, 2024

hmm, i still hit high memory usage here (14GB at max, running with --release hit around 16GB):
command used:

cargo build --features monitoring_prom,slog_json --profile release-lite

this was on a 64GB system though, i'm going to try on a low memory VM and see if can OOM

@wileyj
Copy link
Contributor

wileyj commented Mar 28, 2024

running on a VM with 8Gb of memory, the usage maxed out at 6.13GB used.
as predicted, this did extend the compile time by a little, but it seemed acceptable.

nice work @jbencin !

wileyj
wileyj previously approved these changes Mar 28, 2024
Copy link
Contributor

@wileyj wileyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some README updates requested since there are changes being made there, but otherwsie looks good!

@wileyj
Copy link
Contributor

wileyj commented Mar 28, 2024

ping @moodmosaic

@jbencin jbencin force-pushed the chore/release-lite-profile branch from a2706d2 to cf4fab4 Compare April 1, 2024 14:49
@jbencin jbencin enabled auto-merge April 1, 2024 14:50
@jbencin jbencin requested a review from moodmosaic April 1, 2024 14:50
@wileyj
Copy link
Contributor

wileyj commented Apr 1, 2024

@obycode if you're so inclined, i'd be interested if this profile works on your armv7 pi

@obycode
Copy link
Contributor

obycode commented Apr 2, 2024

@obycode if you're so inclined, i'd be interested if this profile works on your armv7 pi

Sure. To clarify, you want me to try this build on the pi, right?

@obycode
Copy link
Contributor

obycode commented Apr 2, 2024

I still hit a problem on there.

LLVM ERROR: out of memory
Allocation failed
error: could not compile `stackslib` (lib)

I wouldn't make this platform a blocker though.

@wileyj
Copy link
Contributor

wileyj commented Apr 2, 2024

I still hit a problem on there.

LLVM ERROR: out of memory
Allocation failed
error: could not compile `stackslib` (lib)

I wouldn't make this platform a blocker though.

good data to have, thanks for checking. agreed this shouldn't be a blocker. buy new hardware @obycode lol

@jbencin jbencin added this pull request to the merge queue Apr 2, 2024
Merged via the queue into stacks-network:next with commit c383bdd Apr 2, 2024
1 of 2 checks passed
@moodmosaic
Copy link
Member

FWIW, I tested this on both Ubuntu ARM and Ubuntu x64 on 8GB VMs and worked like a charm. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants