Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generating stacking signatures from b58 addresses #4600

Merged
merged 4 commits into from Apr 1, 2024

Conversation

hstove
Copy link
Contributor

@hstove hstove commented Mar 27, 2024

This fixes an issue where the generate-stacking-signature command inside the signer CLI would fail when a p2pkh address was provided as an argument.

jferrant
jferrant previously approved these changes Mar 28, 2024
stacks-signer/src/cli.rs Outdated Show resolved Hide resolved
@hstove hstove requested a review from jferrant March 28, 2024 14:06
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 5.30973% with 107 lines in your changes are missing coverage. Please review.

Project coverage is 67.32%. Comparing base (2686009) to head (0338c99).

Additional details and impacted files
@@             Coverage Diff             @@
##             next    #4600       +/-   ##
===========================================
- Coverage   83.46%   67.32%   -16.14%     
===========================================
  Files         470      470               
  Lines      332151   332256      +105     
  Branches      317      317               
===========================================
- Hits       277220   223701    -53519     
- Misses      54923   108547    +53624     
  Partials        8        8               
Files Coverage Δ
stackslib/src/util_lib/signed_structured_data.rs 95.69% <100.00%> (-2.13%) ⬇️
stacks-signer/src/cli.rs 0.00% <0.00%> (-35.05%) ⬇️

... and 275 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2686009...0338c99. Read the comment docs.

@hstove hstove enabled auto-merge March 28, 2024 15:42
@hstove hstove added this pull request to the merge queue Mar 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 28, 2024
@wileyj wileyj added this pull request to the merge queue Apr 1, 2024
Merged via the queue into next with commit c26e00c Apr 1, 2024
1 of 2 checks passed
@hstove hstove deleted the feat/signer-fix-parsing-btc-address branch April 1, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stacks-signer generate-stacking-signature CLI parses BTC address incorrectly
5 participants