New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: generating stacking signatures from b58 addresses #4600
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #4600 +/- ##
===========================================
- Coverage 83.46% 67.32% -16.14%
===========================================
Files 470 470
Lines 332151 332256 +105
Branches 317 317
===========================================
- Hits 277220 223701 -53519
- Misses 54923 108547 +53624
Partials 8 8
... and 275 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
This fixes an issue where the
generate-stacking-signature
command inside the signer CLI would fail when a p2pkh address was provided as an argument.stacks-signer generate-stacking-signature
CLI parses BTC address incorrectly #4596