Add delegate-stack-increase command #4607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/pox-4-stateful-property-testing #4607 +/- ##
========================================================================
+ Coverage 83.33% 83.37% +0.03%
========================================================================
Files 470 470
Lines 332151 332151
Branches 317 317
========================================================================
+ Hits 276806 276918 +112
+ Misses 55337 55225 -112
Partials 8 8 see 30 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
friedger
reviewed
Mar 29, 2024
contrib/core-contract-tests/tests/pox-4/pox_DelegateStackIncreaseCommand.ts
Show resolved
Hide resolved
moodmosaic
reviewed
Mar 30, 2024
There was a problem hiding this comment.
LGTM; just a few comments (naming, types). Awaiting for @friedger's response though I think the assertion you linked is what he meant.
contrib/core-contract-tests/tests/pox-4/pox-4.stateful-prop.test.ts
Outdated
Show resolved
Hide resolved
contrib/core-contract-tests/tests/pox-4/pox_DelegateStackIncreaseCommand.ts
Outdated
Show resolved
Hide resolved
contrib/core-contract-tests/tests/pox-4/pox_DelegateStackIncreaseCommand.ts
Outdated
Show resolved
Hide resolved
#4607 (comment) Co-authored-by: Nikos Baxevanis <nikos.baxevanis@gmail.com>
|
Merging into |
moodmosaic
merged commit b33cdfd
into
feat/pox-4-stateful-property-testing
1 check passed
moodmosaic
pushed a commit
that referenced
this pull request
Apr 1, 2024
moodmosaic
added a commit
that referenced
this pull request
Apr 1, 2024
#4607 (comment) Co-authored-by: Nikos Baxevanis <nikos.baxevanis@gmail.com>
moodmosaic
pushed a commit
that referenced
this pull request
Apr 11, 2024
… lock period comment #4607 (comment)
moodmosaic
added a commit
that referenced
this pull request
Apr 11, 2024
#4607 (comment) Co-authored-by: Nikos Baxevanis <nikos.baxevanis@gmail.com>
moodmosaic
pushed a commit
that referenced
this pull request
Apr 11, 2024
moodmosaic
pushed a commit
that referenced
this pull request
Apr 11, 2024
… lock period comment #4607 (comment)
moodmosaic
added a commit
that referenced
this pull request
Apr 11, 2024
#4607 (comment) Co-authored-by: Nikos Baxevanis <nikos.baxevanis@gmail.com>
moodmosaic
pushed a commit
that referenced
this pull request
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
delegate-stack-increasecommand to the stateful property testing environment. It is part of #4548 and targetsfeat/pox-4-stateful-property-testing(#4550).