Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix delegate stack increase events #4665

Merged
merged 2 commits into from Apr 10, 2024
Merged

fix: fix delegate stack increase events #4665

merged 2 commits into from Apr 10, 2024

Conversation

janniks
Copy link
Contributor

@janniks janniks commented Apr 9, 2024

  • missing ) in injected code was causing an event to not emit

not consensus critical, but very important for the api

@janniks janniks requested review from kantai and obycode April 9, 2024 16:51
kantai
kantai approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@kantai kantai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming the CI passes.

wileyj
wileyj approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@wileyj wileyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copypaste of @kantai comment

zone117x
zone117x approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@zone117x zone117x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

obycode
obycode approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find!

@janniks
Copy link
Contributor Author

janniks commented Apr 9, 2024

Thanks to @rafaelcr 🕵

@kantai kantai changed the base branch from develop to release/2.5.0.0.0 April 10, 2024 16:49
@kantai kantai merged commit e14022a into release/2.5.0.0.0 Apr 10, 2024
1 check passed
@janniks janniks deleted the fix/fix-delegate-stack-increase-events branch April 10, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kantai kantai kantai approved these changes

@zone117x zone117x zone117x approved these changes

@obycode obycode obycode approved these changes

@wileyj wileyj wileyj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@janniks @kantai @zone117x @obycode @wileyj