Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add signer startup logging #4679

Merged
merged 2 commits into from Apr 15, 2024

Conversation

hstove
Copy link
Contributor

@hstove hstove commented Apr 12, 2024

This is the same code as #4678 , but targeted to the release branch, in hopes that we can get this included in the next RC. I think it's best to keep both PRs open, otherwise we'll have to pull from the release branch into develop (instead of the other way around as usual)

This adds a simple log when the signer is started with the signer's configuration information. The goal is just to help signers ensure their signer is configured as expected. It also provides the signer's STX address and public key.

I've also added a check-config command which validates a config file and outputs the same startup logging information.

Copy link
Contributor

@wileyj wileyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@wileyj wileyj requested a review from a team April 12, 2024 19:24
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wileyj wileyj merged commit 8f87583 into release/2.5.0.0.0 Apr 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants