New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: signer monitoring server #4719
Conversation
One thought is that it'd be good to have some timing metrics here, like roundtrip time for signer -> node RPC calls. EDIT: added ✅ |
78c38ad
to
544fcf6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, just had a few comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. No additional comments outside of those Aaron already covered. Will approve once those are addressed. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
stacks-signer
#4707This adds an (optional) metrics/monitoring server the the
stacks-signer
. It's designed similarly to the node's metrics server, where the server runs optionally and behind amonitoring_prom
feature flag.There is a new signer config option,
metrics_endpoint
, which specifies where the server should listen.There are a bunch of metrics that are relevant to signer operation, but I might have missed some things that would be good to add! Please let me know if you think a metric is missing or should be changed.
The available routes exposed are:
With these routes, my hope is that this can help with signers answering the "is this thing running correctly" question.