Add/update block height keywords in Clarity #4745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update the docs for `block-height` to explain its removal in Clarity 3.
In addition to specifying a minimum version, when a builtin is first available, we can now also specify a maximum version, after which the builtin is no longer available. This is needed for `block-height`, which will not be available starting in Clarity 3.
`block-height` can no longer be used in Clarity 3 and above and will cause an analysis error. In its place is `stacks-block-height`.
Handle the `tenure-height` keyword in Clarity3, and using the same logic for `block-height` in Clarity 1 or 2.
|
I'm still checking on a couple of the integration tests, but @kantai, when you have some time, could you take a look at the approach here and let me know if you see anything troublesome. 🙏 |
|
Somehow related is the get-tenure-info #4716 |
With this commit, undo the MARF changes following the mechanism used for `block-height` and replace it with a Clarity based solution.
obycode
force-pushed
the
feat/stacks-block-height
branch
from
ba0f3cc
to
d8ee58e
Compare
obycode
force-pushed
the
feat/stacks-block-height
branch
from
fc5b94e
to
2dc5bc3
Compare
jcnelson
reviewed
May 7, 2024
jcnelson
reviewed
May 7, 2024
kantai
previously approved these changes
May 13, 2024
5 tasks
jcnelson
reviewed
May 14, 2024
jcnelson
reviewed
May 14, 2024
jcnelson
reviewed
May 14, 2024
jcnelson
reviewed
May 14, 2024
jcnelson
reviewed
May 14, 2024
jcnelson
reviewed
May 14, 2024
jcnelson
reviewed
May 14, 2024
jcnelson
reviewed
May 14, 2024
Also including some other improvements from PR review.
obycode
force-pushed
the
feat/stacks-block-height
branch
from
472c9a1
to
2b4b1c1
Compare
This is necessary after the new check was added to ensure that the tenure height is not set before epoch 3.0.
Ensure new keywords are still handled as expected.
kantai
approved these changes
May 15, 2024
jcnelson
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding support for
stacks-block-heightandtenure-heightin Clarity 3. This also includes using thetenure-heightlogic forblock-heightlogic in Clarity 1 and 2.Applicable issues
block-heightin Nakamoto #3943Additional info (benefits, drawbacks, caveats)
Checklist
docs/rpc/openapi.yamlandrpc-endpoints.mdfor v2 endpoints,event-dispatcher.mdfor new events)clarity-benchmarkingrepobitcoin-tests.yml