Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooling improvements ( Flow => TS, prettier, eslint ) #77

Open
Akirtovskis opened this issue Feb 22, 2022 · 1 comment
Open

Tooling improvements ( Flow => TS, prettier, eslint ) #77

Akirtovskis opened this issue Feb 22, 2022 · 1 comment

Comments

@Akirtovskis
Copy link
Contributor

Hey, it's me and @pradel .

We got a grant to improve the subdomain registrar performance, which is critical for Sigle and perhaps could be reused later on for other apps.

Here is a link to said grant : stacksgov/grants-program#282

M1 in the grant application contains several suggestions for tooling improvements such as:

  • Migrating Flow to TypeScript
    • Do you want to keep using Babel or move to Typescript compiler similarly to how it's implemented with Stacks.js and stacks blockchain api?
  • Setting up Prettier
    • Do you want us to add git Hooks with Husky?
  • Setting up Eslint
  • Setting up Jest
    • Do you want to keep using Tape or switch to Jest?

We are keen to hear what's your feedback regarding introducing the aforementioned tools to improve developer experience.

@asimm241 @CharlieC3

@CharlieC3
Copy link
Member

@Akirtovskis Nice, glad to hear it! While Hiro does host a registrar, this is technically a Stacks Foundation project. So I'm going to loop in @wileyj and @jcnelson for how they'd like to proceed, but will provide some feedback of my own.

Do you want to keep using Babel or move to Typescript compiler similarly to how it's implemented with Stacks.js and stacks blockchain api?

Depends on your budget and effort required, but casting those aside I think aligning with the Stacks.js and API projects would be ideal and encourage developers contributing to those projects to consider this one as well.

Do you want us to add git Hooks with Husky?

Yes please, and commitlint as well if possible. I've installed this in some Hiro Systems projects via the following:

npm i --save-dev husky @commitlint/{config-conventional,cli}

npx husky install

# Add hook
npx husky add .husky/commit-msg 'npx --no-install commitlint --edit'

Do you want to keep using Tape or switch to Jest?

I'm not as familiar with Tape as I am Jest, and would say this should probably be up to the developer's preference. The only mark against Tape I've read as that it does not allow test concurrency nor does it have a mock framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants