feat: update eslint config #80
Conversation
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
==========================================
+ Coverage 58.19% 58.22% +0.02%
==========================================
Files 8 8
Lines 665 663 -2
==========================================
- Hits 387 386 -1
+ Misses 278 277 -1
Continue to review full report at Codecov.
|
|
@CharlieC3 this is the first PR updating the lint config according to patterns used in other Stacks projects. Still facing some flow issues though in the CI. Do you have any idea what might be wrong here? 👀 |
|
@CharlieC3 @wileyj any more pointers on how to go about it? 👀 |
|
@CharlieC3 @wileyj any more pointers on how to go about it? 👀 |
|
@Akirtovskis Looks like I would suggest updating the .flowconfig file to ignore performing static analysis on the |
|
@CharlieC3 @wileyj that indeed was the case. Sorry that it took a bit more time to figure this out due to me first time touching flow 😃 |
feat: fix eslint config fix: cleanup fix: temp remove flow types feat: remove src from flow ignore fix: revert flow config fix: revert changes of config fix: remove the extra line feat: fix with removing node_modules from flow fix: upd ignore config of flow fix: update flow fix: upd node modules fix: upd flow config once more fix: flowconfig ignore updates fix: update flowconfig ignore
Akirtovskis
force-pushed
the
feature/migrate-lint-config
branch
from
01bd7d2
to
86fc2f4
Compare
|
@CharlieC3 any other feedbacks from you or are we good to go for this one? |
|
@Akirtovskis I'm not a primary maintainer for this repo, I think @asimm241 should be able to help you get it merged. |
|
@asimm241 hey hey! Did you have a chance to look at this? |
1 similar comment
|
@asimm241 hey hey! Did you have a chance to look at this? |
|
Sorry @Akirtovskis i missed the I'm inclined to approve this since it's not changing any of the base code. |
|
Sorry about the delay guys, This skipped my attention. Thanks for bumping it up. I'll start on it tomorrow. |
| module.exports = { | ||
| root: true, | ||
| parser: "@babel/eslint-parser", | ||
| plugins: ["eslint-plugin-prettier"], |
There was a problem hiding this comment.
do we want to apply prettier to the flow files or just the typescript ones?
| node: true, | ||
| commonjs: true, | ||
| }, | ||
| parserOptions: { |
There was a problem hiding this comment.
should this go inside the overrides section?
There was a problem hiding this comment.
There have to be both parser options, otherwise pipeline fail with some config error related to that.
There was a problem hiding this comment.
We might want to revisit eslintrc.js once all the files migrated to .ts. Otherwise LGTM!
|
@asimm241 updated TS version as you requested and pipelines green now, so should be good to 🚀 |
|
🎉 This PR is included in version 1.1.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
Issue briefly discussed : #77
This is part of M1 of : Subdomain registrar improvement stacksgov/grants-program#282
Type of change
Config update | code formatting improvement
Does this introduce a breaking change?
No breaking change!