Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python scripts from v2.x to v3.7+ #175

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

stephengaito
Copy link

@stephengaito stephengaito commented Mar 8, 2024

In order to retire the use of python versions which no-longer have security patches, I have:

  • Changed all instances of python2 to python.
  • Updated print statements to be compatible with v3.7+
  • Changed calls to next on FileIO streams (which no longer support next) to readline
  • Added rstrip() to lines read from an FileIO stream so that double newlines were not introduced
    • these extra newlines were confusing the use of "block-mathematic-quotes" ('$$')
  • Added an explicit text=True in the POpen call in git_version

The above changes were "tested" by building a local copy of the Stacks-project using make all

@aisejohan
Copy link
Member

I have a question: after testing, did you check if the outcomes are the same as with the original version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants