Add SIP-022 sign-offs and update status #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obycode
force-pushed
the
tech-cab-signoff
branch
from
2d17528
to
4f0bd41
Compare
whoabuddy
reviewed
Apr 26, 2023
|
Also would this PR be the best place to change the status to Recommended given the sign-offs? |
The governance CAB counted 4 yes votes to both hard forks for SIP-022, one abstained vote, and approves them both.
whoabuddy
changed the title
|
Linking my earlier reply, in case it gets lost in the resolved convo: I was able to commit my suggestion and updated it to include the CAB titles per the convo. Updated the title of the issue, and think we found a good flow for these moving forward. |
|
Adding a note that we should probably update the README as well here? |
jcnelson
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does it make sense for the CAB chairs to open a PR like this upon approval?