Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata for NFTs #18

Closed
wants to merge 7 commits into from
Closed

Metadata for NFTs #18

wants to merge 7 commits into from

Conversation

friedger
Copy link
Contributor

This PR

  • adds a SIP about how metadata for NFTs are defined

@hstove
Copy link
Contributor

hstove commented Mar 18, 2021

For this SIP, I would ask "why"? I definitely agree that a standard for metadata is necessary. However, why should we keep it on-chain?

One reason to keep it on-chain is so that other contracts can consume this information. But, for metadata, why do they need to? Would an external contract ever need to do some logic based on this contract's mime-type, or image-url? Perhaps there is a registry for only JPEG NFTs. But, in that case, you cannot guarantee that the actual type of the image is JPEG - that's just what the contract says.

Another reason might be to provide some guarantee as a client that the information returned from an HTTP request to get-token-uri is not changing, or is not returning different data to different clients. In that case, storing the hash of the result of that HTTP request would be sufficient.

@friedger
Copy link
Contributor Author

friedger commented Nov 5, 2021

superseded by #44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants