Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ujson 2.0.x doesn't compatible with Orquesta #192

Closed
userlocalhost opened this issue Mar 24, 2020 · 1 comment
Closed

The ujson 2.0.x doesn't compatible with Orquesta #192

userlocalhost opened this issue Mar 24, 2020 · 1 comment
Labels

Comments

@userlocalhost
Copy link
Member

The ujson library that orquesta uses major upgraded on Mar 8, 2020. But it doesn't compatible with current Orquesta.
(c.f. https://pypi.org/project/ujson/#history)

Following code is am example to confirm it.

from orquesta import conducting
from orquesta.specs import native as native_specs
from orquesta import statuses
from orquesta.utils import jsonify as json_util

wf_def = """
version: 1.0

vars:
  - xs:
    - fee

tasks:
  task1:
    with: <% ctx(xs) %>
    action: core.echo message=<% item() %>
"""

spec = native_specs.WorkflowSpec(wf_def)

conductor = conducting.WorkflowConductor(spec)
conductor.request_workflow_status(statuses.RUNNING)

actual_tasks = conductor.get_next_tasks()
json_util.deepcopy(actual_tasks)

Case of using ujson(v1.35)

スクリーンショット 2020-03-24 17 45 02

Case of using ujson(v2.0.0)

スクリーンショット 2020-03-24 17 44 05

Case of using ujson(v2.0.2 (current latest version))

スクリーンショット 2020-03-24 17 44 34

@userlocalhost
Copy link
Member Author

userlocalhost commented Apr 1, 2020

Thanks to the following fixing,
https://github.com/StackStorm/orquesta/pull/194/files#diff-a35273175fc0128bccb8ad3986ccebb6R64

I confirm that this issue has also fixed as below. So I'll close this issue.
スクリーンショット 2020-04-01 14 56 47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants