Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use K8s PodPresets #12

Closed
arm4b opened this issue Sep 20, 2018 · 1 comment
Closed

Use K8s PodPresets #12

arm4b opened this issue Sep 20, 2018 · 1 comment
Labels
enhancement New feature or request K8s
Milestone

Comments

@arm4b
Copy link
Member

arm4b commented Sep 20, 2018

Moved from https://github.com/StackStorm/st2enterprise-dockerfiles/issues/83

It turns out that instead of sharing same volumes, files, secrets and ENV vars for each Deployment, we can just create PodPresets for each resource like volume, vars, secrets with selectors that will apply resource sharing with specific containers.
This would help to avoid resource/code duplication and slightly simplify K8s objects.

See

@arm4b arm4b added enhancement New feature or request K8s labels Sep 20, 2018
@arm4b arm4b added this to the v3.1 milestone Oct 12, 2018
@arm4b arm4b added the good first issue Good for newcomers label Aug 23, 2019
@cognifloyd
Copy link
Member

cognifloyd commented Jul 6, 2021

PodPresets were removed in kubernetes 1.20:

The v1alpha1 PodPreset API and admission plugin has been removed with no built-in replacement. Admission webhooks can be used to modify pods on creation. (kubernetes/kubernetes#94090, ...)
See: https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.20.md

Admission Controllers is the replacement, however it requires running an additional process in the k8s control plane.
I looked at adding my some of my changes via such an admissions controller, but I don't want to run or maintain such a controller at this point; Instead I opted for direct changes to the helm templates instead.

As this is no longer "low hanging fruit", I'm going to close this.

@cognifloyd cognifloyd removed the good first issue Good for newcomers label Jul 6, 2021
cognifloyd pushed a commit that referenced this issue May 17, 2022
Updating values.yaml to have the exmaple more consistent iwth others …
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request K8s
Projects
None yet
Development

No branches or pull requests

2 participants