add a test

stacktracejs · Sep 15, 2019 · efb3913 · efb3913
1 parent b506512
commit efb3913
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/spec/stackframe-spec.js b/spec/stackframe-spec.js
@@ -13,6 +13,17 @@ describe('StackFrame', function() {
             };
             expect(fn).toThrow();
         });
+
+        it('works with objects with null prototype', function() {
+            var obj = Object.create(null);
+            obj.fileName = 'foo.js';
+            obj.functionName = 'foo';
+            obj.lineNumber = 1;
+            obj.columnNumber = 42
+            var sf = new StackFrame(obj);
+
+            expect(sf.fileName).toEqual('foo.js');
+        });
     });
 
     describe('#setFunctionName', function() {

diff --git a/stackframe.js b/stackframe.js
@@ -34,8 +34,9 @@
     var props = booleanProps.concat(numericProps, stringProps, arrayProps);
 
     function StackFrame(obj) {
+        if (!obj) return;
         for (var i = 0; i < props.length; i++) {
-            if (obj && obj[props[i]] !== undefined) {
+            if (obj[props[i]] !== undefined) {
                 this['set' + _capitalize(props[i])](obj[props[i]]);
             }
         }